Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to prevent HDUNAME duplicates #17

Open
FerreolS opened this issue Mar 1, 2022 · 2 comments
Open

How to prevent HDUNAME duplicates #17

FerreolS opened this issue Mar 1, 2022 · 2 comments
Assignees

Comments

@FerreolS
Copy link
Member

FerreolS commented Mar 1, 2022

there should be a mechanism duplication of HDU names: let say at the end of 50 iteration of a run, the final image HDU name is IMAGE-OI OUTPUT50 (as stated in sec 3.2). If the user want to continue the run for 50 more iteration, then both INIT_IMG and LAST_IMG will have the same HDU name pointing on different images. This is not possible we should define clearly how to cope with this issue.

Originally posted by @FerreolS in #15 (comment)

@jsy1001
Copy link
Contributor

jsy1001 commented Mar 2, 2022

A possible solution would be to add a keyword (say HDUPREFX) to the input parameters, to specify the leading text to use in HDUNAME instead of IMAGE-OI OUTPUT. For example:

HDUPREFX  = 'IMAGE-OI RUN3 OUTPUT'

would result in the HDUNAME of the 50th iteration being

HDUNAME  = 'IMAGE-OI RUN3 OUTPUT50'

OImaging would be responsible for ensuring that the prefix didn't clash with any pre-existing HDUs.

@FerreolS
Copy link
Member Author

FerreolS commented Mar 7, 2022

That can be fine. We should probably also think about a fallback behaviour at least to prevent the hduname conflict between input and output is the case the reconstruction in done outside OImaging. The OI-Interface standard should be also a way to lauch reconstruction from the command line (e.g. in batch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants