Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red lined sentences in OI-Interface.pdf #18

Open
FerreolS opened this issue Mar 3, 2022 · 4 comments
Open

Red lined sentences in OI-Interface.pdf #18

FerreolS opened this issue Mar 3, 2022 · 4 comments
Assignees

Comments

@FerreolS
Copy link
Member

FerreolS commented Mar 3, 2022

There is several red lined sentence in OI-Interface.pdf generated by \oops command in OI-Interface.tex.
I assume that corresponds to some ideas not completely settled. Can you reread these few sentences to decide if we should keep it in the definitive version?

My idea is to have a well defined specifications written in OI-Interface.pdf before moving toward adding new algorithms.

@jsy1001
Copy link
Contributor

jsy1001 commented Mar 7, 2022

On the question of whether all of the input parameters are mandatory (first \oops in Table 1 caption) I think the following could safely be optional:

  • TARGET (default: assume the first target; warn if there is more than one)
  • FLUX (default 1)

Note that bsmem doesn't support the stated default for FLUXERR (strict constraint).

I think that any optional parameters must have the same default value regardless of which algorithm is used.

Also, there are parameters that won't be used in certain situations - for example RGL_WGT should be omitted if AUTO_WGT is true. We should spell out these contraints in the document.

@jsy1001
Copy link
Contributor

jsy1001 commented Mar 7, 2022

In §3.2 the red text mentioning LAST_IMG should be in black. Table 3 already includes LAST_IMG.

@jsy1001
Copy link
Contributor

jsy1001 commented Mar 7, 2022

Do we need to accept the suggested INSNAME parameter to support GRAVITY data? Or is there another solution for GRAVITY?

@GillesDuvert
Copy link

I suggest to, as always, use an external tool such as OIExplorer to filter out multiple insnames. before using OImaging.
Wisard knows about insnames, because it needs to find their respective OI_WAVELENGTHs to fill up the output file. But at the moment it uses whatever V2 and T3 it finds in the file, so will use both SC and FT values for GRAVITY, which is, eh, suboptimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants