fix: responses do not need to assert lengths if they were already parsed

Author: JPHutchins

smp/message.py

@@ -127,10 +127,6 @@ def model_post_init(self, _: None) -> None:
                     ](self._COMMAND_ID),
                 ),
             )
-        elif self.header.length != len(data_bytes):
-            raise SMPMalformed(
-                f"header.length {self.header.length} != len(data_bytes) {len(data_bytes)}"
-            )
         self._bytes = cast(smpheader.Header, self.header).BYTES + data_bytes
 
 

tests/test_injected_header.py

@@ -103,33 +103,3 @@ def test_ImageUploadWriteResponse_injected_header() -> None:
 
     assert cast(smphdr.Header, r.header).length == 10
     assert len(r.BYTES) == 10 + smphdr.Header.SIZE
-
-    with pytest.raises(SMPMalformed):
-        r = smpimg.ImageUploadProgressWriteResponse(
-            header=smphdr.Header(
-                op=h.op,
-                version=h.version,
-                flags=h.flags,
-                length=2,
-                group_id=h.group_id,
-                sequence=h.sequence,
-                command_id=h.command_id,
-            ),
-            rc=0,
-            off=0,
-        )
-
-    with pytest.raises(SMPMalformed):
-        r = smpimg.ImageUploadProgressWriteResponse(
-            header=smphdr.Header(
-                op=h.op,
-                version=h.version,
-                flags=h.flags,
-                length=0,
-                group_id=h.group_id,
-                sequence=h.sequence,
-                command_id=h.command_id,
-            ),
-            rc=0,
-            off=0,
-        )