From 3ee1fed10b9fb4f38a6265810a052337289fa129 Mon Sep 17 00:00:00 2001 From: Vitalik Knysh Date: Mon, 8 Apr 2024 20:06:40 +0300 Subject: [PATCH 1/5] Added ConfigureAwait(false) --- LiqPaySDK/LiqPay.SDK/LiqPayClient.cs | 2 +- LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs | 14 ++++++++------ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/LiqPaySDK/LiqPay.SDK/LiqPayClient.cs b/LiqPaySDK/LiqPay.SDK/LiqPayClient.cs index a3e68e4..1532a04 100644 --- a/LiqPaySDK/LiqPay.SDK/LiqPayClient.cs +++ b/LiqPaySDK/LiqPay.SDK/LiqPayClient.cs @@ -54,7 +54,7 @@ private void CheckRequired() public async Task RequestAsync(string path, LiqPayRequest requestParams) { var data = PrepareRequestData(requestParams); - string response = await LiqPayClientHelper.PostAsync(LiqPayConsts.LiqpayApiUrl + path, data, Proxy); + string response = await LiqPayClientHelper.PostAsync($"{LiqPayConsts.LiqpayApiUrl}{path}", data, Proxy).ConfigureAwait(false); return JsonConvert.DeserializeObject(response); } diff --git a/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs b/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs index 74335bf..fe26aca 100644 --- a/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs +++ b/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs @@ -1,6 +1,5 @@ using System.Collections.Generic; using System.IO; -using System.Linq; using System.Net; using System.Net.Http; using System.Text; @@ -8,11 +7,10 @@ namespace LiqPay.SDK { - public class LiqPayClientHelper + public class LiqPayClientHelper { public static async Task PostAsync(string url, Dictionary data, WebProxy proxy = null) { - string urlParameters = null; var parameters = new List(); foreach (var item in data) { @@ -22,7 +20,7 @@ public static async Task PostAsync(string url, Dictionary PostAsync(string url, Dictionary Date: Mon, 8 Apr 2024 20:12:06 +0300 Subject: [PATCH 2/5] Fixed a tabulation and formatting a bit --- LiqPaySDK/LiqPay.SDK/LiqPayClient.cs | 5 ++++- LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/LiqPaySDK/LiqPay.SDK/LiqPayClient.cs b/LiqPaySDK/LiqPay.SDK/LiqPayClient.cs index 1532a04..27c5c89 100644 --- a/LiqPaySDK/LiqPay.SDK/LiqPayClient.cs +++ b/LiqPaySDK/LiqPay.SDK/LiqPayClient.cs @@ -54,7 +54,10 @@ private void CheckRequired() public async Task RequestAsync(string path, LiqPayRequest requestParams) { var data = PrepareRequestData(requestParams); - string response = await LiqPayClientHelper.PostAsync($"{LiqPayConsts.LiqpayApiUrl}{path}", data, Proxy).ConfigureAwait(false); + + string response = await LiqPayClientHelper + .PostAsync($"{LiqPayConsts.LiqpayApiUrl}{path}", data, Proxy) + .ConfigureAwait(false); return JsonConvert.DeserializeObject(response); } diff --git a/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs b/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs index fe26aca..b95ba58 100644 --- a/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs +++ b/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs @@ -7,7 +7,7 @@ namespace LiqPay.SDK { - public class LiqPayClientHelper + public class LiqPayClientHelper { public static async Task PostAsync(string url, Dictionary data, WebProxy proxy = null) { From 6340917a2da7a3301d07609997ba79f46b19e1b9 Mon Sep 17 00:00:00 2001 From: Vitalik Knysh Date: Mon, 8 Apr 2024 20:15:27 +0300 Subject: [PATCH 3/5] Moved stringContent into a separate variable --- LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs b/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs index b95ba58..239bad7 100644 --- a/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs +++ b/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs @@ -29,9 +29,11 @@ public static async Task PostAsync(string url, Dictionary Date: Mon, 8 Apr 2024 20:17:54 +0300 Subject: [PATCH 4/5] Changed string to var before the urlParameters, since it's understandable that it's a string from string.Join() --- LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs b/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs index 239bad7..39c3721 100644 --- a/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs +++ b/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs @@ -30,7 +30,7 @@ public static async Task PostAsync(string url, Dictionary Date: Mon, 8 Apr 2024 20:20:26 +0300 Subject: [PATCH 5/5] Added another ConfigureAwait(false) --- LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs b/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs index 39c3721..828d7b8 100644 --- a/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs +++ b/LiqPaySDK/LiqPay.SDK/LiqPayClientHelper.cs @@ -37,7 +37,7 @@ public static async Task PostAsync(string url, Dictionary