Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download paper Supplementary Information #601

Open
ghost opened this issue Sep 2, 2023 · 7 comments
Open

Download paper Supplementary Information #601

ghost opened this issue Sep 2, 2023 · 7 comments
Labels
status:depends-on-external status:zotero The issue goes back to a problem in Zotero's code and thus cannot be fixed as part of this add-on. type:feature

Comments

@ghost
Copy link

ghost commented Sep 2, 2023

Some papers have a 2nd PDF called SI, which stands for supplementary information. In paleontology, it are mostly data sets, graphs or other calculations which are too detailed to put in the paper itself.

I'would like to request for the browser extension a check if SI PDF is available and if there is one, download it and put it as 2nd PDF in the "file" field (while 1st PDF is the original paper).

@ghost ghost changed the title feature request browser extension: download paper SI feature request browser extension: download paper Supplementary Information Sep 3, 2023
@Siedlerchr Siedlerchr transferred this issue from JabRef/jabref Sep 3, 2023
@ghost
Copy link
Author

ghost commented Sep 5, 2023

Are you interested in adding an experimental checkbox "download supplementary information" in the browser extension? (which is disabled by default)

I asked here and they are working on it: zotero/translators#3129
It's a setting you must enable in zotero translator.

@tobiasdiez
Copy link
Member

Sure, but let's wait until it's actually working on Zotero's side.

@tobiasdiez tobiasdiez added type:feature status:zotero The issue goes back to a problem in Zotero's code and thus cannot be fixed as part of this add-on. status:depends-on-external labels Sep 6, 2023
@tobiasdiez tobiasdiez changed the title feature request browser extension: download paper Supplementary Information Download paper Supplementary Information Sep 6, 2023
@ghost
Copy link
Author

ghost commented Sep 6, 2023

Great!
Thanks a lot for this extension. It's a real fantastic add-on for jabref!

@ror3d
Copy link

ror3d commented Mar 19, 2024

Notice a possible issue with this: I believe, currently, JabRef's linked files might not support downloading multiple files of the same extension.

I haven't properly checked yet, but from looking at the code (and one instance in the past of this or something similar happening, but I didn't test further), it seems like any downloaded file would have the name changed to [bibtexkey] (or whatever you have defined for it) so files might get overwritten (or maybe have some (2) appended, if lucky).

It might be that an extra [] field should be added for the file name pattern like [file_description] so that the description set in the LinkedFile dialog can be used there; such as ArXiv Fulltext PDF, then you could also have ArXiv Supplementary Information or something like that.

@tobiasdiez
Copy link
Member

@ror3d Jabref should actually be able to download such files, and then automatically rename them to avoid the naming conflict. If it's not working correctly, please open a new issue at the main jabref repo. (and best add an easy reproduction using the import via cli argument flag)

@ror3d
Copy link

ror3d commented Mar 26, 2024

Yes, at some point I'll investigate what happened with that.

But still, as the renaming works right now, you would get two files with the same name except one will have "(1)" appended to it, right?

@tobiasdiez
Copy link
Member

yes, that would be the expected behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:depends-on-external status:zotero The issue goes back to a problem in Zotero's code and thus cannot be fixed as part of this add-on. type:feature
Projects
None yet
Development

No branches or pull requests

2 participants