Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly support field-based handling #129

Open
4 tasks
LightArrowsEXE opened this issue Oct 3, 2024 · 0 comments · May be fixed by #140
Open
4 tasks

Properly support field-based handling #129

LightArrowsEXE opened this issue Oct 3, 2024 · 0 comments · May be fixed by #140

Comments

@LightArrowsEXE
Copy link
Member

Currently, every denoiser accepts interlaced input, but none of them actually handle it correctly.

To denoise these types of sources properly, we must:

  1. Separate the fields into their own clips (so one clip that features all the top fields, and one that features all the bottom fields)
  2. Perform processing on both as per usual (this will double the processing required, but inevitable here)
  3. Interleave and double weave them back together, then slice as necessary.

Theoretically, nothing is stopping us from implementing these for every denoiser besides figuring out a good way to write all that, so I will likely implement these eventually in at least the following denoisers:

  • MVTools
  • BM3D (wolfram plugins, will not do mawen's version to keep it more in line with how it was originally written)
  • nl_means
  • wnnm

But I'll likely look at other denoisers we have wrappers for as well.

LightArrowsEXE added a commit that referenced this issue Oct 3, 2024
@emotion3459 emotion3459 linked a pull request Jan 7, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant