Skip to content

Commit b313e59

Browse files
committed
QA-15315 Backport from jcontent, clearing multiple localized props
1 parent 0fa70dd commit b313e59

File tree

6 files changed

+21
-10
lines changed

6 files changed

+21
-10
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
<yarn.arguments>build:production</yarn.arguments>
5050
<require-capability>osgi.extender;filter:="(osgi.extender=org.jahia.bundles.blueprint.extender.config)"</require-capability>
5151
<jahia-module-signature>MC0CFQCB6Tj/KAJ69o/12IxKX1yVVKkChwIUK3E0DtOtg4CPyj37SoctBH0yMFI=</jahia-module-signature>
52-
<jahia-depends>app-shell=2.7,graphql-dxm-provider=2.19.1,jcontent=2.9</jahia-depends>
52+
<jahia-depends>app-shell=2.7,graphql-dxm-provider=2.22.0,jcontent=2.9</jahia-depends>
5353
<jahia.plugin.version>6.9</jahia.plugin.version>
5454
<import-package>
5555
com.fasterxml.jackson.annotation;version="[2.10,3)",

src/javascript/ContentEditor/updateNode/updateNode.gql-mutation.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,9 @@ export const SavePropertiesMutation = gql`
55
mutation saveNodeProperties(
66
$uuid:String!,
77
$propertiesToSave: [InputJCRProperty],
8-
$propertiesToDelete: [String],
8+
$propertiesToDelete: [InputJCRDeletedProperty],
99
$mixinsToAdd: [String]!,
1010
$mixinsToDelete: [String]!,
11-
$language: String,
1211
$shouldModifyChildren: Boolean!,
1312
$childrenOrder: [String]!,
1413
$shouldRename: Boolean!,
@@ -27,9 +26,7 @@ export const SavePropertiesMutation = gql`
2726
setPropertiesBatch(properties: $propertiesToSave) {
2827
path
2928
}
30-
mutateProperties(names: $propertiesToDelete) {
31-
delete(language: $language)
32-
}
29+
deletePropertiesBatch(properties: $propertiesToDelete)
3330
reorderChildren(names: $childrenOrder) @include(if: $shouldModifyChildren)
3431
node {
3532
...NodeCacheRequiredFields

src/javascript/utils/fields.utils.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,10 @@ function updateValue({field, value, lang, nodeData, sections, mixinsToMutate, pr
100100
(fieldSetName &&
101101
!mixinsToMutate.mixinsToDelete.includes(fieldSetName) &&
102102
(hasNodeMixin(nodeData, fieldSetName) || mixinsToMutate.mixinsToAdd.includes(fieldSetName)))) {
103-
propsToDelete.push(field.propertyName);
103+
propsToDelete.push({
104+
name: field.propertyName,
105+
language: lang
106+
});
104107
}
105108
}
106109
}

src/javascript/utils/fields.utils.spec.js

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,10 @@ describe('EditPanel utils', () => {
281281
formValues: {
282282
[sections[0].fieldSets[2].name + '_prop']: ''
283283
},
284-
ExpectedPropsToDelete: ['prop'],
284+
ExpectedPropsToDelete: [{
285+
language: 'fr',
286+
name: 'prop'
287+
}],
285288
expectedPropsFieldMapping: {
286289
prop: sections[0].fieldSets[2].name + '_prop'
287290
}
@@ -299,7 +302,10 @@ describe('EditPanel utils', () => {
299302
formValues: {
300303
[sections[0].fieldSets[2].name + '_prop']: null
301304
},
302-
ExpectedPropsToDelete: ['prop'],
305+
ExpectedPropsToDelete: [{
306+
language: 'fr',
307+
name: 'prop'
308+
}],
303309
expectedPropsFieldMapping: {
304310
prop: sections[0].fieldSets[2].name + '_prop'
305311
}
@@ -317,7 +323,10 @@ describe('EditPanel utils', () => {
317323
formValues: {
318324
[sections[0].fieldSets[2].name + '_prop']: undefined
319325
},
320-
ExpectedPropsToDelete: ['prop'],
326+
ExpectedPropsToDelete: [{
327+
language: 'fr',
328+
name: 'prop'
329+
}],
321330
expectedPropsFieldMapping: {
322331
prop: sections[0].fieldSets[2].name + '_prop'
323332
}

tests/provisioning-manifest-build.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
- 'mvn:org.jahia.modules/dx-base-demo-components/2.4.0'
2323
- 'mvn:org.jahia.modules/digitall/2.3.0'
2424
- 'mvn:org.jahia.modules/jcontent/2.15.0'
25+
- 'mvn:org.jahia.modules/graphql-dxm-provider/2.22.0-SNAPSHOT'
2526
autoStart: true
2627
uninstallPreviousVersion: true
2728

tests/provisioning-manifest-snapshot.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
- 'mvn:org.jahia.modules/dx-base-demo-templates/3.4.0'
1717
- 'mvn:org.jahia.modules/dx-base-demo-components/2.4.0'
1818
- 'mvn:org.jahia.modules/digitall/2.3.0'
19+
- 'mvn:org.jahia.modules/graphql-dxm-provider/2.22.0-SNAPSHOT'
1920
autoStart: true
2021
uninstallPreviousVersion: true
2122

0 commit comments

Comments
 (0)