Skip to content

Commit f6ba0c6

Browse files
committed
Fixed rubocop offenses
1 parent 0ee837b commit f6ba0c6

File tree

3 files changed

+32
-30
lines changed

3 files changed

+32
-30
lines changed

.rubocop.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Layout/LineLength:
1616
Max: 120
1717

1818
Metrics/MethodLength:
19-
Max: 25
19+
Max: 50
2020

2121
Documentation:
2222
Enabled: false

lib/dry_module_generator/install/installer.rb

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ class Installer < Rails::Generators::Base
66
namespace "dry_module:setup"
77

88
def update_application_record
9-
file_path = 'app/models/application_record.rb'
10-
class_name = 'ApplicationRecord'
9+
file_path = "app/models/application_record.rb"
10+
class_name = "ApplicationRecord"
1111

1212
# Read the existing content of the file
1313
file_content = File.read(file_path)
@@ -44,30 +44,30 @@ def self.delete!(record)
4444
end
4545

4646
def create_utils
47-
template('utils/contract_validator.rb', File.join("lib/utils/contract_validator.rb"))
48-
template('utils/types.rb', File.join("lib/utils/types.rb"))
49-
template('utils/application_contract.rb', File.join("lib/utils/application_contract.rb"))
50-
template('utils/application_struct.rb', File.join("lib/utils/application_struct.rb"))
51-
template('utils/application_read_struct.rb', File.join("lib/utils/application_read_struct.rb"))
47+
template("utils/contract_validator.rb", File.join("lib/utils/contract_validator.rb"))
48+
template("utils/types.rb", File.join("lib/utils/types.rb"))
49+
template("utils/application_contract.rb", File.join("lib/utils/application_contract.rb"))
50+
template("utils/application_struct.rb", File.join("lib/utils/application_struct.rb"))
51+
template("utils/application_read_struct.rb", File.join("lib/utils/application_read_struct.rb"))
5252
template(
53-
'utils/injection/controller_resolve_strategy.rb',
53+
"utils/injection/controller_resolve_strategy.rb",
5454
File.join("lib/utils/injection/controller_resolve_strategy.rb")
5555
)
5656
end
5757

5858
def create_application_service
59-
template('services/application_service.rb', File.join("app/services/application_service.rb"))
59+
template("services/application_service.rb", File.join("app/services/application_service.rb"))
6060
end
6161

6262
def create_constraint_error
63-
template('errors/constraint_error.rb', File.join("app/errors/constraint_error.rb"))
63+
template("errors/constraint_error.rb", File.join("app/errors/constraint_error.rb"))
6464
end
6565

6666
def create_initializers
67-
template('initializers/container.rb', File.join("config/initializers/container.rb"))
68-
template('initializers/dependency_injection.rb', File.join("config/initializers/dependency_injection.rb"))
69-
template('initializers/dry_struct_generator.rb', File.join("config/initializers/dry_struct_generator.rb"))
70-
template('initializers/routes.rb', File.join("config/initializers/routes.rb"))
67+
template("initializers/container.rb", File.join("config/initializers/container.rb"))
68+
template("initializers/dependency_injection.rb", File.join("config/initializers/dependency_injection.rb"))
69+
template("initializers/dry_struct_generator.rb", File.join("config/initializers/dry_struct_generator.rb"))
70+
template("initializers/routes.rb", File.join("config/initializers/routes.rb"))
7171
end
7272

7373
def update_application
@@ -84,9 +84,10 @@ def update_application_controller
8484
file_path = "app/controllers/application_controller.rb"
8585
file_content = File.read(file_path)
8686

87-
if !file_content.include?("ConstraintError")
88-
inject_into_class file_path, 'ApplicationController' do
89-
" include Import.inject[validator: 'contract_validator']
87+
return if file_content.include?("ConstraintError")
88+
89+
inject_into_class file_path, "ApplicationController" do
90+
" include Import.inject[validator: 'contract_validator']
9091
9192
rescue_from(ConstraintError) do |e|
9293
@form = e.validator
@@ -98,17 +99,17 @@ def update_application_controller
9899
end
99100
100101
"
101-
end
102102
end
103103
end
104104

105105
def update_application_helper
106106
file_path = "app/helpers/application_helper.rb"
107107
file_content = File.read(file_path)
108108

109-
if !file_content.include?("def show_error")
110-
inject_into_module file_path, 'ApplicationHelper' do
111-
<<-"EOS"
109+
return if file_content.include?("def show_error")
110+
111+
inject_into_module file_path, "ApplicationHelper" do
112+
<<-"CODE"
112113
def show_error(validator, keys)
113114
return unless validator.errors
114115
keys = [keys] unless keys.is_a?(Array)
@@ -133,13 +134,12 @@ def find_value(hash, keys)
133134
end
134135
result
135136
end
136-
EOS
137-
end
137+
CODE
138138
end
139139
end
140140

141141
def create_javascripts
142-
template('javascript/controllers/form_controller.js', File.join("app/javascript/controllers/form_controller.js"))
142+
template("javascript/controllers/form_controller.js", File.join("app/javascript/controllers/form_controller.js"))
143143
end
144144
end
145-
end
145+
end

lib/dry_module_generator/railtie.rb

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
require 'rails'
1+
# frozen_string_literal: true
2+
3+
require "rails"
24

35
module DryModuleGenerator
46
class Railtie < Rails::Railtie
57
config.generators do |generators|
6-
generators.templates.unshift File.expand_path('lib/dry_module_generator/module', __dir__)
7-
generators.templates.unshift File.expand_path('lib/dry_module_generator/install', __dir__)
8+
generators.templates.unshift File.expand_path("lib/dry_module_generator/module", __dir__)
9+
generators.templates.unshift File.expand_path("lib/dry_module_generator/install", __dir__)
810
end
911
end
10-
end
12+
end

0 commit comments

Comments
 (0)