Add test that attack at distance 2 with range 1 doesn't work

Author: Janiczek

tests/Data/Fight/GeneratorTest.elm

@@ -1,6 +1,6 @@
 module Data.Fight.GeneratorTest exposing (suite)
 
-import Data.Fight as Fight exposing (Action, Opponent, Who)
+import Data.Fight as Fight exposing (Opponent)
 import Data.Fight.AttackStyle as AttackStyle
 import Data.Fight.Generator exposing (Fight)
 import Data.FightStrategy exposing (..)
@@ -15,14 +15,14 @@ import SeqDict
 import SeqSet
 import Test exposing (Test)
 import TestHelpers exposing (..)
-import Time
 
 
 suite : Test
 suite =
     Test.describe "Data.Fight.Generator"
         [ damageNeverNegative
         , meleeAttackAtDistance2WithRange2
+        , meleeAttackAtDistance2WithRange1
         ]
 
 
@@ -53,7 +53,25 @@ meleeAttackAtDistance2WithRange2 =
         \() ->
             let
                 opponent =
-                    { type_ = Fight.Player { name = "Opponent", xp = 0 }, hp = 100, maxHp = 100, maxAp = 10, sequence = 5, traits = SeqSet.empty, perks = SeqDict.empty, caps = 50, items = Dict.empty, drops = [], equippedArmor = Nothing, equippedWeapon = Just Item.SuperSledge, equippedAmmo = Nothing, naturalArmorClass = 5, attackStats = Logic.unarmedAttackStats { special = Special.init, unarmedSkill = 50, traits = SeqSet.empty, perks = SeqDict.empty, level = 1, npcExtraBonus = 0 }, addedSkillPercentages = SeqDict.empty, special = Special.init, fightStrategy = strategy }
+                    { type_ = Fight.Player { name = "Opponent", xp = 0 }
+                    , hp = 100
+                    , maxHp = 100
+                    , maxAp = 10
+                    , sequence = 5
+                    , traits = SeqSet.empty
+                    , perks = SeqDict.empty
+                    , caps = 50
+                    , items = Dict.empty
+                    , drops = []
+                    , equippedArmor = Nothing
+                    , equippedWeapon = Just Item.SuperSledge
+                    , equippedAmmo = Nothing
+                    , naturalArmorClass = 5
+                    , attackStats = Logic.unarmedAttackStats { special = Special.init, unarmedSkill = 50, traits = SeqSet.empty, perks = SeqDict.empty, level = 1, npcExtraBonus = 0 }
+                    , addedSkillPercentages = SeqDict.empty
+                    , special = Special.init
+                    , fightStrategy = strategy
+                    }
 
                 result =
                     Random.step
@@ -80,6 +98,70 @@ meleeAttackAtDistance2WithRange2 =
                 |> Expect.onFail "Expected the attack to succeed"
 
 
+meleeAttackAtDistance2WithRange1 : Test
+meleeAttackAtDistance2WithRange1 =
+    let
+        strategy : FightStrategy
+        strategy =
+            If
+                { condition = Operator { lhs = Distance, op = GT_, rhs = Number 2 }
+                , then_ = Command MoveForward
+                , else_ = Command AttackRandomly
+                }
+    in
+    Test.test "Melee combat at distance 2 with weapon with range 1 shouldn't work" <|
+        \() ->
+            let
+                opponent =
+                    { type_ =
+                        Fight.Player
+                            { name = "Opponent"
+                            , xp = 0
+                            }
+                    , hp = 100
+                    , maxHp = 100
+                    , maxAp = 10
+                    , sequence = 5
+                    , traits = SeqSet.empty
+                    , perks = SeqDict.empty
+                    , caps = 50
+                    , items = Dict.empty
+                    , drops = []
+                    , equippedArmor = Nothing
+                    , equippedWeapon = Just Item.Wakizashi
+                    , equippedAmmo = Nothing
+                    , naturalArmorClass = 5
+                    , attackStats = Logic.unarmedAttackStats { special = Special.init, unarmedSkill = 50, traits = SeqSet.empty, perks = SeqDict.empty, level = 1, npcExtraBonus = 0 }
+                    , addedSkillPercentages = SeqDict.empty
+                    , special = Special.init
+                    , fightStrategy = strategy
+                    }
+
+                result =
+                    Random.step
+                        (Data.Fight.Generator.attack_
+                            Fight.Attacker
+                            { distanceHexes = 2
+                            , attacker = opponent
+                            , attackerAp = 10
+                            , attackerItemsUsed = SeqDict.empty
+                            , target = opponent
+                            , targetAp = 10
+                            , targetItemsUsed = SeqDict.empty
+                            , reverseLog = []
+                            , actionsTaken = 0
+                            }
+                            AttackStyle.MeleeUnaimed
+                            4
+                        )
+                        (Random.initialSeed 3)
+                        |> Tuple.first
+            in
+            result.ranCommandSuccessfully
+                |> Expect.equal False
+                |> Expect.onFail "Expected the attack to fail"
+
+
 fightFuzzer :
     { attacker : Fuzzer Opponent
     , target : Fuzzer Opponent