Skip to content

Limit the parallelism of user Chromium builds to 8 using an alias #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phistuck wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Limit the parallelism of user Chromium builds to 8 using an alias #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7870270
Add an alias for job-limited Ninja
phistuck May 21, 2018
6fb8ccc
Removed the alias before building
phistuck May 21, 2018
92bb685
Removed a stray \
phistuck May 22, 2018
73e92fd
Removed unalias and the explicit job count
phistuck May 22, 2018
e1dae4c
Removed a stray comment
phistuck May 24, 2018
ba664d7
Added a TODO
phistuck May 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chromium/chromium-update.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ RUN cd /home/user/chromium/src \
&& git fetch origin \
&& git reset --hard origin/master \
&& gclient sync --delete --jobs=`nproc` \
&& ninja -C out/Default chrome -j`nproc`
&& ninja -C out/Default chrome
4 changes: 4 additions & 0 deletions chromium/chromium.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ ENV PATH $PATH:/home/user/depot_tools
RUN echo "\n# Add Chromium's depot_tools to the PATH." >> .bashrc \
&& echo "export PATH=\"\$PATH:/home/user/depot_tools\"" >> .bashrc

# Make default Ninja parallelism use 8 parallel jobs.
# TODO(phistuck) - remove this once host-level affinity settings are implemented.
RUN echo "\nalias ninja='ninja -j8'" >> .bash_aliases

# Enable bash completion for git cl.
RUN echo "\n# The next line enables bash completion for git cl." >> .bashrc \
&& echo "if [ -f \"/home/user/depot_tools/git_cl_completion.sh\" ]; then" >> .bashrc \
Expand Down