-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProjectPasskeys: Replace requestedParties
with rpId
, and origins
#9248
Comments
requestedParties
with rpId
, and origins
requestedParties
with rpId
, and origins
code has been committed as part of #9111. |
TODOs:
References : 1. https://passkeys.dev/docs/advanced/related-origins/ |
…o RpId Signed-off-by: Madhumita <madhu@gluu.org>
…ript for attestation and assertion API calls #9248 Signed-off-by: imran-ishaq <imranishaq024@gmail.com>
Signed-off-by: imran-ishaq <imranishaq024@gmail.com>
Signed-off-by: imran-ishaq <imranishaq024@gmail.com>
…tion and assertion API calls #9248 (#9974) * feat(jans-fido2): add origin parameter in Fido2ExternalAuthenticator script for attestation and assertion API calls Signed-off-by: imran-ishaq <imranishaq024@gmail.com> * refactor(docs): add origin parameter in Fido2ExternalAuthenticator script for attestation and assertion API calls #9248 Signed-off-by: imran-ishaq <imranishaq024@gmail.com> * fix(jans-fido2): handle origin if http or https is missing #9248 Signed-off-by: imran-ishaq <imranishaq024@gmail.com> --------- Signed-off-by: imran-ishaq <imranishaq024@gmail.com>
Signed-off-by: imran-ishaq <imranishaq024@gmail.com>
New notes: RP ID is a domain string only, and does not mention a scheme or port number as an origin does. The RP ID of a PublicKeyCredential sets it scope, i.e. it determines the origins on which it may be exercised as follows: The RP ID must be equal to the origin's effective domain, or a registrable suffix of the origin's effective domain. The origin's scheme must be 'https'. The origin's port number is unrestricted. |
…o RpId Signed-off-by: Madhumita <madhu@gluu.org>
…tion and assertion API calls #9248 (#9974) * feat(jans-fido2): add origin parameter in Fido2ExternalAuthenticator script for attestation and assertion API calls Signed-off-by: imran-ishaq <imranishaq024@gmail.com> * refactor(docs): add origin parameter in Fido2ExternalAuthenticator script for attestation and assertion API calls #9248 Signed-off-by: imran-ishaq <imranishaq024@gmail.com> * fix(jans-fido2): handle origin if http or https is missing #9248 Signed-off-by: imran-ishaq <imranishaq024@gmail.com> --------- Signed-off-by: imran-ishaq <imranishaq024@gmail.com>
Signed-off-by: imran-ishaq <imranishaq024@gmail.com>
RP.ID is set one time, and can not be changed. It must be carefully considered, and is integral part of the access control for the authenticat
For jans, this is how we should be doing it:
RP.ID must always be set
RP.ID must be set separately from ORIGINS
RP.ID must be just the HOST part, or FQDN
RP.ID need to have a clear documentation
Origins are a list of origins (protocol + host + port), that must specified by the user separately
TODOs:
if origin returned in ClientDataJson is in the list of allowed origins, then pass
Your origins can be, https://bank.com/ https://auth.bank.com/ https://internal.bank.com/
Origins can be a set, and can change
The text was updated successfully, but these errors were encountered: