Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PREVIOUS BEHAVIOR:
walker generic entry
=>node entries (generic/typed)
=> back towalker typed entry
=>walker typed exit
=> back tonode exits (generic/typed)
=> back towalker generic exit
REFACTORED BEHAVIOR:
walker generic entry
=>walker typed entry
=>node generic entry
=>node typed entry
=>node typed exit
=>node generic exit
=> back towalker typed exit
=>walker generic exit
In this approach, we limit the back and forth of execution to
walker -> node -> walker
. It can also make the execution more "declarative".It's also more direct if we plan in future to support the
with entry
andwith exit
approach