Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR]: Spawn Call #1447

Merged
merged 3 commits into from
Jan 7, 2025
Merged

[REFACTOR]: Spawn Call #1447

merged 3 commits into from
Jan 7, 2025

Conversation

amadolid
Copy link
Collaborator

PREVIOUS BEHAVIOR:
walker generic entry => node entries (generic/typed) => back to walker typed entry => walker typed exit => back to node exits (generic/typed) => back to walker generic exit

REFACTORED BEHAVIOR:
walker generic entry => walker typed entry => node generic entry => node typed entry => node typed exit => node generic exit => back to walker typed exit => walker generic exit

In this approach, we limit the back and forth of execution to walker -> node -> walker. It can also make the execution more "declarative".

It's also more direct if we plan in future to support the with entry and with exit approach

@amadolid amadolid force-pushed the refactor/spawn-call branch from b352568 to 4f3ff0f Compare November 15, 2024 10:32
@amadolid amadolid mentioned this pull request Nov 15, 2024
@amadolid amadolid force-pushed the refactor/spawn-call branch from 4f3ff0f to 8469b00 Compare November 15, 2024 19:05
@amadolid amadolid force-pushed the refactor/spawn-call branch 2 times, most recently from 47326eb to 5002ed8 Compare November 27, 2024 16:53
@amadolid amadolid force-pushed the refactor/spawn-call branch from 5002ed8 to fbf0666 Compare December 9, 2024 12:19
@ypkang
Copy link
Contributor

ypkang commented Jan 6, 2025

@amadolid Let's go ahead and merge this in. Can you add a mardown file that just document the current behavior? You can use the visit_sequence.jac as an example and document the expected call sequence. You can add the markdown to the jac-cloud section of the documentation directory.

@ypkang ypkang closed this Jan 6, 2025
@ypkang ypkang reopened this Jan 6, 2025
@ypkang ypkang self-requested a review January 6, 2025 21:21
Copy link
Contributor

@ypkang ypkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comment above.

@amadolid amadolid requested a review from ypkang January 7, 2025 07:44
@ypkang
Copy link
Contributor

ypkang commented Jan 7, 2025

Made a quick tweak to the markdown. 🚢

Copy link
Contributor

@ypkang ypkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ypkang ypkang merged commit a9ac697 into main Jan 7, 2025
5 checks passed
@ypkang ypkang deleted the refactor/spawn-call branch January 7, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants