queue_runner uses this after destruction

[Kirkezz]

I am using your library as follows:

int getPlayersCount() {
    static int id = 2;
    int result = -1;

    rconpp::rcon_client client(rcon_credentials.ip, rcon_credentials.port, rcon_credentials.password);
    if (client.connected) {
        auto response = client.send_data_sync("list", ++id, rconpp::data_type::SERVERDATA_EXECCOMMAND);
        /* ... */
        std::cout << response.data << std::endl;
    }

    return result;
}

The program crashes with segfault:

I think the problem is that queue_runner uses this after the rcon_client object is destroyed.
With the following changes, segfault no longer occurs:

[Jaskowicz1]

Huh, that is a bizarre one. the deconstructor of rcon_client should kill this queue_runner (as connected becomes false so the while should break).

If that does fix the issue though, I'll gladly add it! Thank you!!

[Kirkezz]

I think the UB still persists here. The problem is that connected becomes false in the middle of a while loop. It also looks like queue_runner is not joinable in destructor.

[Jaskowicz1]

I think the UB still persists here. The problem is that connected becomes false in the middle of a while loop. It also looks like queue_runner is not joinable in destructor.

Hm, that's interesting... Odd why this never came up in testing 🤔

[Jaskowicz1]

ahhhhhh I'm so silly, I understand now.