Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataSource.callback.php - optional config params are required #131

Open
Jemt opened this issue Feb 10, 2020 · 0 comments
Open

DataSource.callback.php - optional config params are required #131

Jemt opened this issue Feb 10, 2020 · 0 comments
Labels
Milestone

Comments

@Jemt
Copy link
Owner

Jemt commented Feb 10, 2020

Some DataSource parameters are described as optional (e.g. XmlTimeOut and XmlMemoryRequired), but if not defined, they cause PHP to emit errors:

image

@Jemt Jemt added the bug label Feb 10, 2020
@Jemt Jemt added this to the SMCMS-JSShop milestone Feb 10, 2020
Jemt added a commit that referenced this issue Feb 12, 2020
This commit enables SMShop to run on multiple sites (primary and subsites) by automatically installing required configuration files.

Also fixed bug in DataSource.callback.php which caused an error due to XmlTimeOut and XmlMemoryRequired not being specified for SMShopTags. These properties are actually optional, but this is currently buggy (see #131).

Futhermore fixed PDF generation (TCPDF) which could triggered "open_basedir restriction in effect" error.

Also moved e-mail templates into separate folder under data/SMShop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant