Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there any plans to add an option to have ESC close the dialog even if a namespace is specified? #119

Open
Shotaro-Yoshinaga-sti opened this issue Jun 14, 2024 · 3 comments
Assignees
Labels
Feature Need to do

Comments

@Shotaro-Yoshinaga-sti
Copy link

I would like to see an option to specify that ESC can close the dialog even if a namespace is specified.

Also, I had a hard time finding out that even when namespace is specified, the dialog cannot be closed with ESC.
Maybe only here

@Shotaro-Yoshinaga-sti Shotaro-Yoshinaga-sti added the Feature Need to do label Jun 14, 2024
@Jenesius
Copy link
Owner

Hello, closing does not work via ESC, because... It is not clear from which namespace exactly the modal window should be closed.
Perhaps it is worth changing this behavior, and when closing ESC, close any windows, regardless of namespace.

@Jenesius
Copy link
Owner

Today I will think about how to solve this problem

@Jenesius Jenesius self-assigned this Jun 14, 2024
@Shotaro-Yoshinaga-sti
Copy link
Author

Shotaro-Yoshinaga-sti commented Jun 20, 2024

I think backgroundClose has the same problem.

because... It is not clear from which namespace exactly the modal window should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Need to do
Projects
None yet
Development

No branches or pull requests

2 participants