Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite/cleanup/simplify ListComboBox code #715

Draft
wants to merge 1 commit into
base: fix-slc-excessive-recomposition
Choose a base branch
from
Draft

Rewrite/cleanup/simplify ListComboBox code #715

wants to merge 1 commit into from

Conversation

rock3r
Copy link
Collaborator

@rock3r rock3r commented Dec 5, 2024 •
edited
Loading

  • Split the editable and non-editable list combo boxes
  • Fix up item state management as it was utter chaos
  • Use the appropriate names for style items
  • Add iconTextGap to list item metrics
  • Only do preview selection when mouse-moving over an item, not when hovering, to reduce glitches when scrolling
  • Fix margins and colours
  • Create PopupManager to track and change a popup's visibility and use it in (List)(Editable)ComboBox
  • More!

Fixes #707
Fixes #710

@rock3r rock3r added bug Something isn't working cleanup Improve the project/tooling and/or get rid of tech debt labels Dec 5, 2024
@rock3r rock3r requested a review from hamen December 5, 2024 17:08
@rock3r rock3r self-assigned this Dec 5, 2024
@hamen hamen mentioned this pull request Dec 6, 2024
Closed
@rock3r
Rewrite/cleanup/simplify ListComboBox code
1bcd3ba 
* Split the editable and non-editable list combo boxes
* Fix up item state management as it was utter chaos
* Use the appropriate names for style items
* Add iconTextGap to list item metrics
* Only do preview selection when mouse-moving over an item, not when
  hovering, to reduce glitches when scrolling
* Fix margins and colours
@rock3r rock3r force-pushed the fix-simple-list-item branch from 8b4ad2a to 1bcd3ba Compare December 10, 2024 12:06
@rock3r rock3r changed the base branch from main to fix-slc-excessive-recomposition December 10, 2024 12:14
@rock3r
Copy link
Collaborator Author

rock3r commented Dec 10, 2024

The CI is red here but it should be fine when #724 is merged

@rock3r rock3r linked an issue Dec 11, 2024 that may be closed by this pull request
Expose icon and text modifiers in SimpleListItem #710
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamen hamen Awaiting requested review from hamen

Assignees

@rock3r rock3r

Labels
bug Something isn't working cleanup Improve the project/tooling and/or get rid of tech debt
Projects
None yet
Milestone
No milestone
1 participant
@rock3r