This repository was archived by the owner on Apr 22, 2025. It is now read-only.
Rewrite/cleanup/simplify ListComboBox code #715
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rock3r
added
bug
* Split the editable and non-editable list combo boxes * Fix up item state management as it was utter chaos * Use the appropriate names for style items * Add iconTextGap to list item metrics * Only do preview selection when mouse-moving over an item, not when hovering, to reduce glitches when scrolling * Fix margins and colours
rock3r
force-pushed
the
fix-simple-list-item
branch
from
8b4ad2a to
1bcd3ba
Compare
|
The CI is red here but it should be fine when #724 is merged |
hamen
added a commit
to rock3r/intellij-community
that referenced
this pull request
Jan 15, 2025
Merge after JetBrains#2905 Reference JetBrains/jewel#715 Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
|
Migrated to IJP as JetBrains/intellij-community#2912 |
intellij-monorepo-bot
pushed a commit
to JetBrains/intellij-community
that referenced
this pull request
Jan 20, 2025
Merge after #2905 Reference JetBrains/jewel#715 Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> closes #2912 GitOrigin-RevId: d0b2a0cb59088752dde6f53e8ec00bdb0169adc8
intellij-monorepo-bot
pushed a commit
to JetBrains/intellij-community
that referenced
this pull request
Mar 12, 2025
Merge after #2905 Reference JetBrains/jewel#715 Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> closes #2912 (cherry picked from commit d0b2a0cb59088752dde6f53e8ec00bdb0169adc8) (cherry picked from commit dde7fb4970b3cda5c819b78d6bd6cc20508b9c11) IJ-MR-155570 GitOrigin-RevId: c0b4da708ff0936fb25e8b7624e78e691ddf6fa6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(List)(Editable)ComboBoxFixes #707
Fixes #710