Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Question: Why not pass parameters as build arguments #32

Open
abjrcode opened this issue Jan 31, 2019 · 0 comments
Open

Design Question: Why not pass parameters as build arguments #32

abjrcode opened this issue Jan 31, 2019 · 0 comments

Comments

@abjrcode
Copy link

This is a question regarding the design of both this image and the full build agent docker image.

I am just wondering why not accept the TeamCity URL and other parameters as docker arguments ARG which you supply during building the container and also bake the build agents config file into the contains writable layer?

That way, images provided by JetBrains become always base images used in FROM clauses and the result is a new container image which you can push, say to ECR repository for instance.
It also avoids the need for mount volumes which aren't available in Fargate for instance.

I know I can copy the code and do what I described, I am just wondering why you didn't take that approach from the beginning
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant