Improve partial form submission validation and synchronization

Author: chiragchhatrala

api/app/Http/Controllers/Forms/PublicFormController.php

@@ -16,6 +16,7 @@
 use Illuminate\Support\Facades\Auth;
 use Illuminate\Support\Facades\Storage;
 use Vinkla\Hashids\Facades\Hashids;
+use Illuminate\Support\Str;
 
 class PublicFormController extends Controller
 {
@@ -98,6 +99,20 @@ private function handlePartialSubmissions(Request $request)
         // Process submission data to extract submission ID
         $submissionData = $this->processSubmissionIdentifiers($request, $request->all());
 
+        // Validate that at least one field has a value
+        $hasValue = false;
+        foreach ($submissionData as $key => $value) {
+            if (Str::isUuid($key) && !empty($value)) {
+                $hasValue = true;
+                break;
+            }
+        }
+        if (!$hasValue) {
+            return $this->error([
+                'message' => 'At least one field must have a value for partial submissions.'
+            ], 422);
+        }
+
         // Explicitly mark this as a partial submission
         $submissionData['is_partial'] = true;
 

client/components/open/forms/OpenCompleteForm.vue

@@ -303,16 +303,16 @@ export default {
       if (form.busy) return
       this.loading = true
 
+      if (this.form?.enable_partial_submissions) {
+        this.partialSubmission.stopSync()
+      }
+
       form.post('/forms/' + this.form.slug + '/answer').then((data) => {
         this.submittedData = form.data()
         useAmplitude().logEvent('form_submission', {
           workspace_id: this.form.workspace_id,
           form_id: this.form.id
         })
-
-        if (this.form?.enable_partial_submissions) {
-          this.partialSubmission.stopSync()
-        }
     
         const payload = clonedeep({
           type: 'form-submitted',
@@ -351,6 +351,10 @@ export default {
           this.confetti.play()
         }
       }).catch((error) => {
+        if (this.form?.enable_partial_submissions) {
+          this.partialSubmission.startSync()
+        }
+      
         console.error(error)
         if (error.response && error.data && error.data.message) {
           useAlert().error(error.data.message)

client/composables/forms/pendingSubmission.js

@@ -31,6 +31,17 @@ export const pendingSubmission = (form) => {
     return pendingSubmission ? JSON.parse(pendingSubmission) : defaultValue
   }
 
+  const setSubmissionHash = (hash) => {
+    set({
+      ...get(),
+      submission_hash: hash
+    })
+  }
+
+  const getSubmissionHash = () => {
+    return get()?.submission_hash ?? null
+  }
+
   const setTimer = (value) => {
     if (import.meta.server) return
     useStorage(formPendingSubmissionTimerKey.value).value = value
@@ -51,6 +62,8 @@ export const pendingSubmission = (form) => {
     set,
     get,
     remove,
+    setSubmissionHash,
+    getSubmissionHash,
     setTimer,
     removeTimer,
     getTimer,

client/composables/forms/usePartialSubmission.js

@@ -12,11 +12,12 @@ export const usePartialSubmission = (form, formData = {}) => {
   let dataWatcher = null
 
   const getSubmissionHash = () => {
-    return submissionHashes.value.get(pendingSubmission.formPendingSubmissionKey.value)
+    return pendingSubmission.getSubmissionHash() ?? submissionHashes.value.get(pendingSubmission.formPendingSubmissionKey.value)
   }
 
   const setSubmissionHash = (hash) => {
     submissionHashes.value.set(pendingSubmission.formPendingSubmissionKey.value, hash)
+    pendingSubmission.setSubmissionHash(hash)
   }
 
   const debouncedSync = () => {
@@ -92,6 +93,8 @@ export const usePartialSubmission = (form, formData = {}) => {
   }
 
   const stopSync = () => {
+    submissionHashes.value = new Map()
+
     if (dataWatcher) {
       dataWatcher()
       dataWatcher = null
@@ -113,7 +116,9 @@ export const usePartialSubmission = (form, formData = {}) => {
     stopSync()
 
     // Final sync attempt before unmounting
-    syncToServer()
+    if(getSubmissionHash()) {
+      syncToServer()
+    }
   })
 
   return {