Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a video extension when user doesn't add one #10

Open
JoelMon opened this issue Jun 13, 2021 · 0 comments
Open

Add a video extension when user doesn't add one #10

JoelMon opened this issue Jun 13, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@JoelMon
Copy link
Owner

JoelMon commented Jun 13, 2021

When the user uses the -o flag, they have to add a video container extension otherwise the program crashes without any indication of what went wrong.

Example

$ scriptx -f nwt_01_Ge_ASL_10_r480P.m4v -v 20 -o Gen10-20
thread 'main' panicked at 'ffmpeg's exit status was FAILURE', /home/joel/.cargo/registry/src/github.com-1ecc6299db9ec823/scriptx-0.2.1/src/ff.rs:191:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Solution

  1. If the user doesn't add an extension, add one by default
  2. Improve error handling to be more informative
@JoelMon JoelMon added bug Something isn't working documentation Improvements or additions to documentation labels Jun 13, 2021
@JoelMon JoelMon added enhancement New feature or request good first issue Good for newcomers and removed bug Something isn't working documentation Improvements or additions to documentation labels Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant