Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running pnpm build script for prod should not result in a dev build #674

Closed
gradywetherbee opened this issue Aug 21, 2024 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@gradywetherbee
Copy link

gradywetherbee commented Aug 21, 2024

Describe the bug
When I quit the development server and run pnpm build, the resulting build still appears to be a dev build.

To Reproduce
Steps to reproduce the behavior:

  1. Run pnpm dev
  2. Hit Cmd/Ctrl + C to kill your terminal
  3. Run pnpm build
  4. Remove the extension in your browser and reload

Expected behavior
Extension should run a clean production build

Screenshots & current behavior
Extension appears to be running a development build still. Extension page shows the following error:

WebSocket connection to 'ws://localhost:8081/' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED
image

Desktop (please complete the following information):

  • OS: MacOS Sonoma
  • Browser: Chrome
  • Node Version: v21.2.0
@gradywetherbee gradywetherbee added the bug Something isn't working label Aug 21, 2024
Copy link

Thank you for your contribution. We will check and reply to you as soon as possible.

@PatrykKuniczak
Copy link
Collaborator

Let's see #477

That's not related to pnpm build but, this occur when you break pnpm dev and then WSS server were stopped, and script from client still trying to connect server and this error occur.

If you clear errors and refresh plugin after build then, you should have working version.

If still it still doesn't work for you, feel free to reopen 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants