Skip to content

Commit 3069fe3

Browse files
committed
fix(plugins): export modules for each plugin
1 parent fae88a5 commit 3069fe3

17 files changed

+77
-39
lines changed

README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ Use ```ScrollSpyElementDirective``` to spy on any element. You must give an uniq
9595

9696
```js
9797
import { NgModule, Component, Injectable, AfterViewInit } from '@angular/core';
98-
import { ScrollSpyElementDirective, ScrollSpyService } from 'ng2-scrollspy';
98+
import { ScrollSpyModule, ScrollSpyService } from 'ng2-scrollspy';
9999

100100
@Injectable()
101101
@Component({
@@ -117,10 +117,11 @@ export class YourComponent implements AfterViewInit {
117117
}
118118

119119
@NgModule({
120-
imports: [ ],
120+
imports: [
121+
ScrollSpyModule
122+
],
121123
declarations: [
122-
AppComponent,
123-
ScrollSpyElementDirective
124+
AppComponent
124125
],
125126
providers: [ ]
126127
})

dist/index.metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"__symbolic":"module","version":1,"metadata":{"NG2SCROLLSPY_FORROOT_GUARD":{"__symbolic":"new","expression":{"__symbolic":"reference","module":"@angular/core","name":"OpaqueToken"},"arguments":["NG2SCROLLSPY_FORROOT_GUARD"]},"ScrollSpyModule":{"__symbolic":"class","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"NgModule"},"arguments":[{"declarations":[{"__symbolic":"reference","module":"./core/window.directive","name":"ScrollSpyDirective"}],"exports":[{"__symbolic":"reference","module":"./core/window.directive","name":"ScrollSpyDirective"}]}]}],"members":{"__ctor__":[{"__symbolic":"constructor","parameterDecorators":[[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Optional"}},{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Inject"},"arguments":[{"__symbolic":"reference","name":"NG2SCROLLSPY_FORROOT_GUARD"}]}]],"parameters":[{"__symbolic":"reference","name":"any"}]}]},"statics":{"forRoot":{"__symbolic":"function","parameters":[],"value":{"ngModule":{"__symbolic":"reference","name":"ScrollSpyModule"},"providers":[{"provide":{"__symbolic":"reference","name":"NG2SCROLLSPY_FORROOT_GUARD"},"useFactory":{"__symbolic":"reference","name":"provideForRootGuard"},"deps":[[{"__symbolic":"reference","module":"./core/service","name":"ScrollSpyService"},{"__symbolic":"new","expression":{"__symbolic":"reference","module":"@angular/core","name":"Optional"}},{"__symbolic":"new","expression":{"__symbolic":"reference","module":"@angular/core","name":"SkipSelf"}}]]},{"__symbolic":"reference","module":"./core/service","name":"ScrollSpyService"},{"__symbolic":"reference","module":"./plugin/index.service","name":"ScrollSpyIndexService"}]}}}}},"exports":[{"from":"./core/service"},{"from":"./core/window.directive"},{"from":"./core/element.directive"},{"from":"./plugin/index.service"}]}
1+
{"__symbolic":"module","version":1,"metadata":{"NG2SCROLLSPY_FORROOT_GUARD":{"__symbolic":"new","expression":{"__symbolic":"reference","module":"@angular/core","name":"OpaqueToken"},"arguments":["NG2SCROLLSPY_FORROOT_GUARD"]},"ScrollSpyModule":{"__symbolic":"class","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"NgModule"},"arguments":[{"declarations":[{"__symbolic":"reference","module":"./core/window.directive","name":"ScrollSpyDirective"},{"__symbolic":"reference","module":"./core/element.directive","name":"ScrollSpyElementDirective"}],"exports":[{"__symbolic":"reference","module":"./core/window.directive","name":"ScrollSpyDirective"},{"__symbolic":"reference","module":"./core/element.directive","name":"ScrollSpyElementDirective"}]}]}],"members":{"__ctor__":[{"__symbolic":"constructor","parameterDecorators":[[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Optional"}},{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Inject"},"arguments":[{"__symbolic":"reference","name":"NG2SCROLLSPY_FORROOT_GUARD"}]}]],"parameters":[{"__symbolic":"reference","name":"any"}]}]},"statics":{"forRoot":{"__symbolic":"function","parameters":[],"value":{"ngModule":{"__symbolic":"reference","name":"ScrollSpyModule"},"providers":[{"provide":{"__symbolic":"reference","name":"NG2SCROLLSPY_FORROOT_GUARD"},"useFactory":{"__symbolic":"reference","name":"provideForRootGuard"},"deps":[[{"__symbolic":"reference","module":"./core/service","name":"ScrollSpyService"},{"__symbolic":"new","expression":{"__symbolic":"reference","module":"@angular/core","name":"Optional"}},{"__symbolic":"new","expression":{"__symbolic":"reference","module":"@angular/core","name":"SkipSelf"}}]]},{"__symbolic":"reference","module":"./core/service","name":"ScrollSpyService"},{"__symbolic":"reference","module":"./plugin/index.service","name":"ScrollSpyIndexService"}]}}}}},"exports":[{"from":"./core/service"},{"from":"./core/window.directive"},{"from":"./core/element.directive"},{"from":"./plugin/index.service"}]}

dist/plugin/affix.metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"__symbolic":"module","version":1,"metadata":{},"exports":[{"from":"./affix.directive"}]}
1+
{"__symbolic":"module","version":1,"metadata":{"ScrollSpyAffixModule":{"__symbolic":"class","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"NgModule"},"arguments":[{"declarations":[{"__symbolic":"reference","module":"./affix.directive","name":"ScrollSpyAffixDirective"}],"exports":[{"__symbolic":"reference","module":"./affix.directive","name":"ScrollSpyAffixDirective"}]}]}]}},"exports":[{"from":"./affix.directive"}]}

dist/plugin/index.metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"__symbolic":"module","version":1,"metadata":{},"exports":[{"from":"./index.service"},{"from":"./index.directive"},{"from":"./index.component"}]}
1+
{"__symbolic":"module","version":1,"metadata":{"ScrollSpyIndexModule":{"__symbolic":"class","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"NgModule"},"arguments":[{"imports":[{"__symbolic":"reference","module":"@angular/common","name":"CommonModule"},{"__symbolic":"reference","module":"@angular/router","name":"RouterModule"}],"declarations":[{"__symbolic":"reference","module":"./index.directive","name":"ScrollSpyIndexDirective"},{"__symbolic":"reference","module":"./index.component","name":"ScrollSpyIndexRenderComponent"}],"exports":[{"__symbolic":"reference","module":"./index.directive","name":"ScrollSpyIndexDirective"},{"__symbolic":"reference","module":"./index.component","name":"ScrollSpyIndexRenderComponent"}]}]}]}},"exports":[{"from":"./index.service"},{"from":"./index.directive"},{"from":"./index.component"}]}

dist/plugin/infinite.metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"__symbolic":"module","version":1,"metadata":{},"exports":[{"from":"./infinite.directive"}]}
1+
{"__symbolic":"module","version":1,"metadata":{"ScrollSpyInfinitexModule":{"__symbolic":"class","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"NgModule"},"arguments":[{"declarations":[{"__symbolic":"reference","module":"./infinite.directive","name":"ScrollSpyInfiniteDirective"}],"exports":[{"__symbolic":"reference","module":"./infinite.directive","name":"ScrollSpyInfiniteDirective"}]}]}]}},"exports":[{"from":"./infinite.directive"}]}

dist/plugin/parallax.metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"__symbolic":"module","version":1,"metadata":{},"exports":[{"from":"./parallax.directive"}]}
1+
{"__symbolic":"module","version":1,"metadata":{"ScrollSpyParallaxModule":{"__symbolic":"class","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"NgModule"},"arguments":[{"declarations":[{"__symbolic":"reference","module":"./parallax.directive","name":"ScrollSpyParallaxDirective"}],"exports":[{"__symbolic":"reference","module":"./parallax.directive","name":"ScrollSpyParallaxDirective"}]}]}]}},"exports":[{"from":"./parallax.directive"}]}

src/core/element.directive.spec.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { TestBed, ComponentFixture, fakeAsync, inject } from '@angular/core/test
44
import { advance, createRoot } from '../test.mocks';
55

66
import { ScrollSpyModule, ScrollSpyService } from '../index';
7-
import { ScrollSpyElementDirective } from './element.directive';
87

98
describe('core element.directive', () => {
109

@@ -17,8 +16,7 @@ describe('core element.directive', () => {
1716
ScrollSpyModule.forRoot()
1817
],
1918
declarations: [
20-
RootCmp,
21-
ScrollSpyElementDirective
19+
RootCmp
2220
]
2321
});
2422

src/index.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import {
99

1010
import { ScrollSpyService } from './core/service';
1111
import { ScrollSpyDirective } from './core/window.directive';
12+
import { ScrollSpyElementDirective } from './core/element.directive';
1213

1314
import { ScrollSpyIndexService } from './plugin/index.service';
1415

@@ -27,8 +28,8 @@ export function provideForRootGuard(scrollSpyService: ScrollSpyService): any {
2728
}
2829

2930
@NgModule({
30-
declarations: [ ScrollSpyDirective ],
31-
exports: [ ScrollSpyDirective ]
31+
declarations: [ ScrollSpyDirective, ScrollSpyElementDirective ],
32+
exports: [ ScrollSpyDirective, ScrollSpyElementDirective ]
3233
})
3334
export class ScrollSpyModule {
3435
constructor(@Optional() @Inject(NG2SCROLLSPY_FORROOT_GUARD) guard: any) {}

src/plugin/affix.directive.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { TestBed, ComponentFixture, fakeAsync, inject } from '@angular/core/test
44
import { advance, createRoot } from '../test.mocks';
55

66
import { ScrollSpyModule } from '../index';
7-
import { ScrollSpyAffixDirective } from './affix.directive';
7+
import { ScrollSpyAffixModule } from './affix';
88

99
describe('plugin affix.directive', () => {
1010

@@ -13,11 +13,11 @@ describe('plugin affix.directive', () => {
1313
beforeEach(() => {
1414
TestBed.configureTestingModule({
1515
imports: [
16-
ScrollSpyModule.forRoot()
16+
ScrollSpyModule.forRoot(),
17+
ScrollSpyAffixModule
1718
],
1819
declarations: [
19-
RootCmp,
20-
ScrollSpyAffixDirective
20+
RootCmp
2121
]
2222
});
2323
});

src/plugin/affix.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,11 @@
1+
import { NgModule } from '@angular/core';
2+
13
export * from './affix.directive';
4+
5+
import { ScrollSpyAffixDirective } from './affix.directive';
6+
7+
@NgModule({
8+
declarations: [ ScrollSpyAffixDirective ],
9+
exports: [ ScrollSpyAffixDirective ]
10+
})
11+
export class ScrollSpyAffixModule {}

src/plugin/index.component.spec.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ import { RouterTestingModule } from '@angular/router/testing';
66
import { advance, createRoot } from '../test.mocks';
77

88
import { ScrollSpyModule } from '../index';
9-
import { ScrollSpyIndexDirective } from './index.directive';
10-
import { ScrollSpyIndexRenderComponent } from './index.component';
9+
import { ScrollSpyIndexModule } from './index';
1110

1211
describe('plugin index.render.directive', () => {
1312

@@ -17,11 +16,10 @@ describe('plugin index.render.directive', () => {
1716
TestBed.configureTestingModule({
1817
imports: [
1918
RouterTestingModule,
20-
ScrollSpyModule.forRoot()
19+
ScrollSpyModule.forRoot(),
20+
ScrollSpyIndexModule
2121
],
2222
declarations: [
23-
ScrollSpyIndexRenderComponent,
24-
ScrollSpyIndexDirective,
2523
RootCmp
2624
]
2725
});

src/plugin/index.directive.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { TestBed, ComponentFixture, fakeAsync, inject } from '@angular/core/test
44
import { advance, createRoot } from '../test.mocks';
55

66
import { ScrollSpyModule } from '../index';
7-
import { ScrollSpyIndexDirective } from './index.directive';
7+
import { ScrollSpyIndexModule } from './index';
88
import { ScrollSpyIndexService } from './index.service';
99

1010
describe('plugin index.directive', () => {
@@ -14,11 +14,11 @@ describe('plugin index.directive', () => {
1414
beforeEach(() => {
1515
TestBed.configureTestingModule({
1616
imports: [
17-
ScrollSpyModule.forRoot()
17+
ScrollSpyModule.forRoot(),
18+
ScrollSpyIndexModule
1819
],
1920
declarations: [
20-
RootCmp,
21-
ScrollSpyIndexDirective
21+
RootCmp
2222
]
2323
});
2424
});

src/plugin/index.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
import { NgModule } from '@angular/core';
2+
import { CommonModule } from '@angular/common';
3+
import { RouterModule } from '@angular/router';
4+
15
export * from './index.service';
26
export * from './index.directive';
37
export * from './index.component';
8+
9+
import { ScrollSpyIndexDirective } from './index.directive';
10+
import { ScrollSpyIndexRenderComponent } from './index.component';
11+
12+
@NgModule({
13+
imports: [ CommonModule, RouterModule ],
14+
declarations: [ ScrollSpyIndexDirective, ScrollSpyIndexRenderComponent ],
15+
exports: [ ScrollSpyIndexDirective, ScrollSpyIndexRenderComponent ]
16+
})
17+
export class ScrollSpyIndexModule {}

src/plugin/infinite.directive.spec.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ import { TestBed, ComponentFixture, fakeAsync, inject, tick } from '@angular/cor
44
import { advance, createRoot } from '../test.mocks';
55

66
import { ScrollSpyModule } from '../index';
7-
import { ScrollSpyElementDirective } from '../index';
8-
import { ScrollSpyInfiniteDirective } from './infinite.directive';
7+
import { ScrollSpyInfiniteModule } from './infinite';
98

109
describe('plugin infinite.directive', () => {
1110

@@ -18,13 +17,12 @@ describe('plugin infinite.directive', () => {
1817

1918
TestBed.configureTestingModule({
2019
imports: [
21-
ScrollSpyModule.forRoot()
20+
ScrollSpyModule.forRoot(),
21+
ScrollSpyInfiniteModule
2222
],
2323
declarations: [
2424
RootCmp,
25-
RootElementCmp,
26-
ScrollSpyElementDirective,
27-
ScrollSpyInfiniteDirective
25+
RootElementCmp
2826
]
2927
});
3028
});

src/plugin/infinite.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,11 @@
1+
import { NgModule } from '@angular/core';
2+
13
export * from './infinite.directive';
4+
5+
import { ScrollSpyInfiniteDirective } from './infinite.directive';
6+
7+
@NgModule({
8+
declarations: [ ScrollSpyInfiniteDirective ],
9+
exports: [ ScrollSpyInfiniteDirective ]
10+
})
11+
export class ScrollSpyInfiniteModule {}

src/plugin/parallax.directive.spec.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ import { TestBed, ComponentFixture, fakeAsync, inject } from '@angular/core/test
44
import { advance, createRoot } from '../test.mocks';
55

66
import { ScrollSpyModule } from '../index';
7-
import { ScrollSpyElementDirective } from '../index';
8-
import { ScrollSpyParallaxDirective } from './parallax.directive';
7+
import { ScrollSpyParallaxModule } from './parallax';
98

109
describe('plugin parallax.directive', () => {
1110

@@ -15,13 +14,12 @@ describe('plugin parallax.directive', () => {
1514
beforeEach(() => {
1615
TestBed.configureTestingModule({
1716
imports: [
18-
ScrollSpyModule.forRoot()
17+
ScrollSpyModule.forRoot(),
18+
ScrollSpyParallaxModule
1919
],
2020
declarations: [
2121
RootCmp,
22-
RootElementCmp,
23-
ScrollSpyElementDirective,
24-
ScrollSpyParallaxDirective
22+
RootElementCmp
2523
]
2624
});
2725
});

src/plugin/parallax.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,11 @@
1+
import { NgModule } from '@angular/core';
2+
13
export * from './parallax.directive';
4+
5+
import { ScrollSpyParallaxDirective } from './parallax.directive';
6+
7+
@NgModule({
8+
declarations: [ ScrollSpyParallaxDirective ],
9+
exports: [ ScrollSpyParallaxDirective ]
10+
})
11+
export class ScrollSpyParallaxModule {}

0 commit comments

Comments
 (0)