add tests to BadVisibilityOnSharedPrimitiveVariables

Author: JuditKnoll

spotbugs-tests/src/test/java/edu/umd/cs/findbugs/detect/BadVisibilityOnSharedPrimitiveVariablesTest.java

@@ -27,6 +27,21 @@ void failurePath_fieldWithBadVisibility_whenOtherMethodIsSynchronized() {
         assertBugInMethodAtLine(BUG_TYPE, "SynchronizedMethodAndBadVisibilityOnField", "shutdown", 17);
     }
 
+    @Test
+    void failurePath_fieldWithBadVisibility_whenSetAndGetAreReordered() {
+        performAnalysis("multithreaded/sharedPrimitiveVariables/FieldWithBadVisibilityReordered.class");
+        assertBugTypeCount(BUG_TYPE, 1);
+        assertBugInMethodAtLine(BUG_TYPE, "FieldWithBadVisibilityReordered", "run", 12);
+    }
+
+    @Test
+    void failurePath_fieldWithBadVisibility_whenClassHasTwoSetters() {
+        performAnalysis("multithreaded/sharedPrimitiveVariables/FieldWithBadVisibilityTwoSetters.class");
+        assertBugTypeCount(BUG_TYPE, 2);
+        assertBugInMethodAtLine(BUG_TYPE, "FieldWithBadVisibilityTwoSetters", "shutdown", 18);
+        assertBugInMethodAtLine(BUG_TYPE, "FieldWithBadVisibilityTwoSetters", "up", 22);
+    }
+
     @Test
     void failurePath_fieldWithBadVisibility_whenClassExtendsThread() {
         performAnalysis("multithreaded/sharedPrimitiveVariables/FieldWithBadVisibilityThread.class");

spotbugsTestCases/src/java/multithreaded/sharedPrimitiveVariables/FieldWithBadVisibilityReordered.java

@@ -0,0 +1,20 @@
+package multithreaded.sharedPrimitiveVariables;
+
+public class FieldWithBadVisibilityReordered extends Thread {
+    private boolean done = false;
+
+    public void shutdown() {
+        done = true;
+    }
+
+    @Override
+    public void run() {
+        while (!done) {
+            try {
+                Thread.currentThread().sleep(1000);
+            } catch(InterruptedException ie) {
+                Thread.currentThread().interrupt();
+            }
+        }
+    }
+}

spotbugsTestCases/src/java/multithreaded/sharedPrimitiveVariables/FieldWithBadVisibilityTwoSetters.java

@@ -0,0 +1,24 @@
+package multithreaded.sharedPrimitiveVariables;
+
+public class FieldWithBadVisibilityTwoSetters extends Thread {
+    private boolean done = false;
+
+    @Override
+    public void run() {
+        while (!done) {
+            try {
+                Thread.currentThread().sleep(1000);
+            } catch(InterruptedException ie) {
+                Thread.currentThread().interrupt();
+            }
+        }
+    }
+
+    public void shutdown() {
+        done = true;
+    }
+
+    public void up() {
+        done = false;
+    }
+}