@@ -135,24 +135,19 @@ HRESULT vkd3d_create_buffer_explicit_usage(struct d3d12_device *device,
135
135
136
136
HRESULT vkd3d_create_buffer (struct d3d12_device * device ,
137
137
const D3D12_HEAP_PROPERTIES * heap_properties , D3D12_HEAP_FLAGS heap_flags ,
138
- const D3D12_RESOURCE_DESC1 * desc , const char * tag , VkVkd3dTypeJUICE vkd3dType , VkBuffer * vk_buffer )
138
+ const D3D12_RESOURCE_DESC1 * desc , const char * tag , VkBuffer * vk_buffer )
139
139
{
140
140
const struct vkd3d_vk_device_procs * vk_procs = & device -> vk_procs ;
141
141
VkExternalMemoryBufferCreateInfo external_info ;
142
142
const bool sparse_resource = !heap_properties ;
143
143
VkBufferCreateInfo buffer_info ;
144
- VkD3D12ResourceCreateInfoJUICE d3d12_info ;
145
144
D3D12_HEAP_TYPE heap_type ;
146
145
VkResult vr ;
147
146
148
147
heap_type = heap_properties ? heap_properties -> Type : D3D12_HEAP_TYPE_DEFAULT ;
149
148
150
- d3d12_info .sType = VK_STRUCTURE_TYPE_D3D12_RESOURCE_CREATE_INFO_JUICE ;
151
- d3d12_info .pNext = NULL ;
152
- d3d12_info .vkd3dType = vkd3dType ;
153
-
154
149
buffer_info .sType = VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO ;
155
- buffer_info .pNext = & d3d12_info ;
150
+ buffer_info .pNext = NULL ;
156
151
buffer_info .flags = 0 ;
157
152
buffer_info .size = desc -> Width ;
158
153
@@ -951,24 +946,17 @@ static HRESULT vkd3d_create_image(struct d3d12_device *device,
951
946
const D3D12_HEAP_PROPERTIES * heap_properties , D3D12_HEAP_FLAGS heap_flags ,
952
947
const D3D12_RESOURCE_DESC1 * desc , struct d3d12_resource * resource ,
953
948
UINT num_castable_formats , const DXGI_FORMAT * castable_formats ,
954
- VkVkd3dTypeJUICE type , VkVkd3dTypeJUICE type , VkImage * vk_image )
949
+ VkImage * vk_image )
955
950
{
956
951
const struct vkd3d_vk_device_procs * vk_procs = & device -> vk_procs ;
957
952
struct vkd3d_image_create_info create_info ;
958
- VkD3D12ResourceCreateInfoJUICE d3d12_info ;
959
953
VkResult vr ;
960
954
HRESULT hr ;
961
955
962
956
if (FAILED (hr = vkd3d_get_image_create_info (device , heap_properties ,
963
957
heap_flags , desc , resource , num_castable_formats , castable_formats , & create_info )))
964
958
return hr ;
965
959
966
- d3d12_info .sType = VK_STRUCTURE_TYPE_D3D12_RESOURCE_CREATE_INFO_JUICE ;
967
- d3d12_info .vkd3dType = type ;
968
-
969
- d3d12_info .pNext = create_info .image_info .pNext ;
970
- create_info .image_info .pNext = & d3d12_info ;
971
-
972
960
/* In case we get address binding callbacks, ensure driver knows it's not a sparse bind that happens async. */
973
961
vkd3d_address_binding_tracker_mark_user_thread ();
974
962
@@ -3291,9 +3279,9 @@ static HRESULT d3d12_resource_create_vk_resource(struct d3d12_resource *resource
3291
3279
if (resource -> desc .Dimension == D3D12_RESOURCE_DIMENSION_BUFFER )
3292
3280
{
3293
3281
if (FAILED (hr = vkd3d_create_buffer (device , heap_properties ,
3294
- D3D12_HEAP_FLAG_NONE , & resource -> desc , & resource -> res . vk_buffer )))
3282
+ D3D12_HEAP_FLAG_NONE , & resource -> desc ,
3295
3283
(resource -> flags & VKD3D_RESOURCE_RESERVED ) ? "sparse-buffer" : "user-buffer" ,
3296
- VK_VKD3D_TYPE_NONE_JUICE , & resource -> res .vk_buffer )))
3284
+ & resource -> res .vk_buffer )))
3297
3285
return hr ;
3298
3286
3299
3287
if (vkd3d_address_binding_tracker_active (& device -> address_binding_tracker ))
@@ -3312,7 +3300,7 @@ static HRESULT d3d12_resource_create_vk_resource(struct d3d12_resource *resource
3312
3300
if (FAILED (hr = vkd3d_create_image (device , heap_properties ,
3313
3301
D3D12_HEAP_FLAG_NONE , & resource -> desc , resource ,
3314
3302
num_castable_formats , castable_formats ,
3315
- VK_VKD3D_TYPE_NONE_JUICE , & resource -> res .vk_image )))
3303
+ & resource -> res .vk_image )))
3316
3304
return hr ;
3317
3305
3318
3306
if (vkd3d_address_binding_tracker_active (& device -> address_binding_tracker ))
@@ -5422,8 +5410,6 @@ static void vkd3d_create_buffer_srv(vkd3d_cpu_descriptor_va_t desc_va,
5422
5410
5423
5411
if (desc -> ViewDimension == D3D12_SRV_DIMENSION_RAYTRACING_ACCELERATION_STRUCTURE )
5424
5412
{
5425
- // damcclos: TODO
5426
-
5427
5413
if (!desc -> RaytracingAccelerationStructure .Location )
5428
5414
{
5429
5415
/* There is no concrete descriptor to use here,
@@ -5470,8 +5456,6 @@ static void vkd3d_create_buffer_srv(vkd3d_cpu_descriptor_va_t desc_va,
5470
5456
5471
5457
if (!resource )
5472
5458
{
5473
- // damcclos: TODO
5474
-
5475
5459
if (mutable_uses_single_descriptor )
5476
5460
{
5477
5461
d3d12_descriptor_heap_write_null_descriptor_template (desc_va ,
@@ -5526,7 +5510,6 @@ static void vkd3d_create_buffer_srv(vkd3d_cpu_descriptor_va_t desc_va,
5526
5510
}
5527
5511
else
5528
5512
{
5529
- //VkD3D12BufferViewCreateInfoJUICE bufferViewCreateInfo;
5530
5513
VkDeviceSize stride = desc -> Format == DXGI_FORMAT_UNKNOWN
5531
5514
? desc -> Buffer .StructureByteStride :
5532
5515
vkd3d_get_format (device , desc -> Format , false)-> byte_count ;
@@ -5537,17 +5520,7 @@ static void vkd3d_create_buffer_srv(vkd3d_cpu_descriptor_va_t desc_va,
5537
5520
5538
5521
vkd3d_init_write_descriptor_set (& vk_write [vk_write_count ], & d , binding ,
5539
5522
vk_descriptor_type , & descriptor_info [vk_write_count ]);
5540
-
5541
- /*bufferViewCreateInfo.sType = VK_STRUCTURE_TYPE_D3D12_BUFFER_VIEW_CREATE_INFO_JUICE;
5542
- bufferViewCreateInfo.pNext = NULL;
5543
- bufferViewCreateInfo.d3d12Type = VK_D3D12_DESC_VIEW_TYPE_SHADER_RESOURCE_JUICE;
5544
- bufferViewCreateInfo.buffer = descriptor_info[vk_write_count].buffer.buffer;
5545
- bufferViewCreateInfo.offset = descriptor_info[vk_write_count].buffer.offset;
5546
- bufferViewCreateInfo.size = descriptor_info[vk_write_count].buffer.range;
5547
-
5548
- VK_CALL(vkCreateBufferViewJUICE(resource->mem.device_allocation.vk_memory, &bufferViewCreateInfo));*/
5549
-
5550
- vk_write_count ++ ;
5523
+ vk_write_count ++ ;
5551
5524
}
5552
5525
}
5553
5526
@@ -5598,19 +5571,7 @@ static void vkd3d_create_buffer_srv(vkd3d_cpu_descriptor_va_t desc_va,
5598
5571
descriptor_info [vk_write_count ].buffer_view = view ? view -> vk_buffer_view : VK_NULL_HANDLE ;
5599
5572
vkd3d_init_write_descriptor_set (& vk_write [vk_write_count ], & d , binding ,
5600
5573
vk_descriptor_type , & descriptor_info [vk_write_count ]);
5601
-
5602
- /*if (descriptor_info[vk_write_count].buffer_view)
5603
- {
5604
- VkD3D12BindBufferViewInfoJUICE bindViewInfo;
5605
- bindViewInfo.sType = VK_STRUCTURE_TYPE_D3D12_BIND_BUFFER_VIEW_INFO_JUICE;
5606
- bindViewInfo.pNext = NULL;
5607
- bindViewInfo.d3d12Type = VK_D3D12_DESC_VIEW_TYPE_SHADER_RESOURCE_JUICE;
5608
- bindViewInfo.bufferView = descriptor_info[vk_write_count].buffer_view;
5609
-
5610
- VK_CALL(vkBindBufferViewJUICE(resource->mem.device_allocation.vk_memory, &bindViewInfo));
5611
- }*/
5612
-
5613
- vk_write_count ++ ;
5574
+ vk_write_count ++ ;
5614
5575
}
5615
5576
}
5616
5577
@@ -5933,18 +5894,6 @@ static void vkd3d_create_texture_srv(vkd3d_cpu_descriptor_va_t desc_va,
5933
5894
{
5934
5895
vkd3d_init_write_descriptor_set (& vk_writes [vk_write_count ++ ], & d , binding ,
5935
5896
VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE , & descriptor_info );
5936
- //VK_CALL(vkUpdateDescriptorSets(device->vk_device, 1, &vk_write, 0, NULL));
5937
-
5938
- //if (descriptor_info.image.imageView)
5939
- //{
5940
- // VkD3D12BindImageViewInfoJUICE bindViewInfo;
5941
- // bindViewInfo.sType = VK_STRUCTURE_TYPE_D3D12_BIND_IMAGE_VIEW_INFO_JUICE;
5942
- // bindViewInfo.pNext = NULL;
5943
- // bindViewInfo.d3d12Type = VK_D3D12_DESC_VIEW_TYPE_SHADER_RESOURCE_JUICE;
5944
- // bindViewInfo.imageView = descriptor_info.image.imageView;
5945
-
5946
- // VK_CALL(vkBindImageViewJUICE(resource->mem.device_allocation.vk_memory, &bindViewInfo));
5947
- //}
5948
5897
}
5949
5898
5950
5899
/* Clear out sibling typed descriptor if appropriate.
@@ -6203,8 +6152,6 @@ static void vkd3d_create_buffer_uav(vkd3d_cpu_descriptor_va_t desc_va, struct d3
6203
6152
6204
6153
if (!resource )
6205
6154
{
6206
- // damcclos: TODO
6207
-
6208
6155
if (mutable_uses_single_descriptor )
6209
6156
{
6210
6157
d3d12_descriptor_heap_write_null_descriptor_template (desc_va ,
@@ -6328,18 +6275,6 @@ static void vkd3d_create_buffer_uav(vkd3d_cpu_descriptor_va_t desc_va, struct d3
6328
6275
6329
6276
vkd3d_init_write_descriptor_set (& vk_write [vk_write_count ], & d , binding ,
6330
6277
vk_descriptor_type , & descriptor_info [vk_write_count ]);
6331
-
6332
- /*if (descriptor_info[vk_write_count].buffer_view)
6333
- {
6334
- VkD3D12BindBufferViewInfoJUICE bindViewInfo;
6335
- bindViewInfo.sType = VK_STRUCTURE_TYPE_D3D12_BIND_BUFFER_VIEW_INFO_JUICE;
6336
- bindViewInfo.pNext = NULL;
6337
- bindViewInfo.d3d12Type = VK_D3D12_DESC_VIEW_TYPE_UNORDERED_ACCESS_JUICE;
6338
- bindViewInfo.bufferView = descriptor_info[vk_write_count].buffer_view;
6339
-
6340
- VK_CALL(vkBindBufferViewJUICE(resource->mem.device_allocation.vk_memory, &bindViewInfo));
6341
- }*/
6342
-
6343
6278
vk_write_count ++ ;
6344
6279
}
6345
6280
}
@@ -6488,18 +6423,6 @@ static void vkd3d_create_texture_uav(vkd3d_cpu_descriptor_va_t desc_va,
6488
6423
{
6489
6424
vkd3d_init_write_descriptor_set (& vk_writes [vk_write_count ++ ], & d , binding ,
6490
6425
VK_DESCRIPTOR_TYPE_STORAGE_IMAGE , & descriptor_info );
6491
- //VK_CALL(vkUpdateDescriptorSets(device->vk_device, 1, &vk_write, 0, NULL));
6492
-
6493
- //if (descriptor_info.image.imageView)
6494
- //{
6495
- // VkD3D12BindImageViewInfoJUICE bindViewInfo;
6496
- // bindViewInfo.sType = VK_STRUCTURE_TYPE_D3D12_BIND_IMAGE_VIEW_INFO_JUICE;
6497
- // bindViewInfo.pNext = NULL;
6498
- // bindViewInfo.d3d12Type = VK_D3D12_DESC_VIEW_TYPE_UNORDERED_ACCESS_JUICE;
6499
- // bindViewInfo.imageView = descriptor_info.image.imageView;
6500
-
6501
- // VK_CALL(vkBindImageViewJUICE(resource->mem.device_allocation.vk_memory, &bindViewInfo));
6502
- //}
6503
6426
}
6504
6427
6505
6428
/* Clear out sibling typed descriptor if appropriate.
@@ -7774,7 +7697,7 @@ static HRESULT d3d12_descriptor_heap_init_data_buffer(struct d3d12_descriptor_he
7774
7697
heap_flags = D3D12_HEAP_FLAG_ALLOW_ONLY_BUFFERS ;
7775
7698
7776
7699
if (FAILED (hr = vkd3d_create_buffer (device , & heap_info , heap_flags , & buffer_desc ,
7777
- "descriptor-buffer" , VK_VKD3D_TYPE_DESCRIPTOR_HEAP_SHADER_VISIBLE_JUICE , & descriptor_heap -> vk_buffer )))
7700
+ "descriptor-buffer" , & descriptor_heap -> vk_buffer )))
7778
7701
return hr ;
7779
7702
7780
7703
property_flags = device -> memory_info .descriptor_heap_memory_properties ;
@@ -8574,7 +8497,7 @@ HRESULT d3d12_query_heap_create(struct d3d12_device *device, const D3D12_QUERY_H
8574
8497
buffer_desc .Flags = D3D12_RESOURCE_FLAG_ALLOW_UNORDERED_ACCESS ;
8575
8498
8576
8499
if (FAILED (hr = vkd3d_create_buffer (device , & heap_properties ,
8577
- D3D12_HEAP_FLAG_ALLOW_ONLY_BUFFERS , & buffer_desc , "query-heap" , VK_VKD3D_TYPE_QUERY_DATA_JUICE , & object -> vk_buffer )))
8500
+ D3D12_HEAP_FLAG_ALLOW_ONLY_BUFFERS , & buffer_desc , "query-heap" , & object -> vk_buffer )))
8578
8501
{
8579
8502
vkd3d_free (object );
8580
8503
return hr ;
0 commit comments