sub_materialize(::AbstractQuasiArray) (#60)

* sub_materialize(::AbstractQuasiArray)

* Update test_quasisubarray.jl

* increase coverage

Author: dlfivefifty

Project.toml

@@ -1,7 +1,7 @@
 name = "QuasiArrays"
 uuid = "c4ea9172-b204-11e9-377d-29865faadc5c"
 authors = ["Sheehan Olver <solver@mac.com>"]
-version = "0.4.7"
+version = "0.4.8"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

src/dense.jl

@@ -39,12 +39,7 @@
     else
         A*A^(p-1)
     end
-function (^)(A::AbstractQuasiMatrix{T}, p::Integer) where T<:Integer
-    # make sure that e.g. [1 1;1 0]^big(3)
-    # gets promotes in a similar way as 2^big(3)
-    TT = promote_op(^, T, typeof(p))
-    return convert(AbstractQuasiMatrix{TT}, A)^p
-end
+
 # function integerpow(A::AbstractQuasiMatrix{T}, p) where T
 #     TT = promote_op(^, T, typeof(p))
 #     return (TT == T ? A : copyto!(similar(A, TT), A))^Integer(p)

src/subquasiarray.jl

@@ -326,6 +326,7 @@ end
 
 @inline sub_materialize(_, V::AbstractQuasiArray, _) = QuasiArray(V)
 @inline sub_materialize(V::SubQuasiArray) = sub_materialize(MemoryLayout(typeof(V)), V)
+@inline sub_materialize(A::AbstractQuasiArray) = A # already materialized
 
 
 ###

test/test_dense.jl

@@ -12,5 +12,16 @@ import LazyArrays: ApplyStyle, MulStyle
         @test A^4 ≈ A*A*A*A
         @test A^big(2) isa QuasiArray{Float64}
         @test A^(-1) == inv(A) == QuasiArray(inv(A.parent), A.axes)
+
+        V = view(A,:,:)
+        @test V^1 == A
+        @test V^2 == A^2
+        @test V^3 == A^3
+        @test_broken V^(-1) == inv(A)
+
+        A = QuasiArray([1 2; 3 4], (0:0.5:0.5, 0:0.5:0.5))
+        V = view(A,:,:)
+        @test V^1 == A
+        @test V^2 == A^2
     end
 end

test/test_quasisubarray.jl

@@ -293,6 +293,8 @@ using QuasiArrays, Base64, Test
         @test V2 isa SubArray
         @test parent(V2) isa QuasiArray
         @test V2 == A[0:0.5:0.5,1:0.5:1.5]
+
+        @test QuasiArrays.sub_materialize(A) == A
     end
 
     @testset "Show" begin