Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapCube fails to show errors when ispar=true #449

Closed
lazarusA opened this issue Oct 15, 2024 · 1 comment · Fixed by #452
Closed

mapCube fails to show errors when ispar=true #449

lazarusA opened this issue Oct 15, 2024 · 1 comment · Fixed by #452
Labels
bug Something isn't working foot-gun

Comments

@lazarusA
Copy link
Collaborator

let's try to debug and fix.

@lazarusA lazarusA added bug Something isn't working foot-gun labels Oct 15, 2024
@felixcremer
Copy link
Member

This is because we call pmap with on_error=identity. This was introduced by @meggart in #265. I am not sure, what is the use case to not just rethrow the error?
Do we have cases where we expect a failure at certain parts of the data but we would like the mapCube to still succeed? That would be something for the on_error keyword.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working foot-gun
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants