New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash equality disagreement for MutableTangent on 32bit (/x86 CI) #658

Closed

oxinabox opened this issue Jan 29, 2024 · 0 comments · Fixed by #659

Labels

32 bit bug

Member

oxinabox commented Jan 29, 2024

Since #626 (probably revealed in that CI but overlooked)
the CI has been failing on 32 bit from one of tested added in that PR

 == and hash: Test Failed at /home/runner/work/ChainRulesCore.jl/ChainRulesCore.jl/test/tangent_types/structural_tangent.jl:473
  Expression: hash(MutableTangent{MDemo}(; x = 1.0f0)) == hash(MutableTangent{MDemo}(; x = 1.0))
   Evaluated: 0x9d88e406 == 0x848801a3

There is no reasons obvious to me why these would disagree.
It is required that values that are == (like 1.0 and 1.0f0) also hash that same

The text was updated successfully, but these errors were encountered:

oxinabox added bug 32 bit labels

oxinabox mentioned this issue

Fix hash(::MutableTangent) on 32 bit #659

Merged

oxinabox closed this as completed in #659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment