Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welch's Method for IAAFT or AAFT #162

Open
duodenum96 opened this issue May 15, 2024 · 5 comments
Open

Welch's Method for IAAFT or AAFT #162

duodenum96 opened this issue May 15, 2024 · 5 comments

Comments

@duodenum96
Copy link

The neurophysiological data I'm analyzing have long time series (let's say 5-10 minutes) however the frequencies of interest tend to be between 1 to 40 Hz. A common practice in our field is to estimate the power spectrum via Welch's method of averaging periodograms. Would doing the same be worthwile in IAAFT method? If so, I would be willing to contribute this to the package, since I'm already going to implement it for my own project.

@Datseris
Copy link
Member

Datseris commented May 16, 2024

Hi, thanks for considering a contribution!

However, it is not clear to me what you wish to contribute :S ...

Do you want to contribute a new method for computing Power Spectra? If so, this doesn't really belong in this package. Probably DSP.jl makes more sense.

Do you instead want to enhance the current IAFFT algorithm to instead of use the standard FFT to compute the spectrum, to instead use the Welch's method? Sure, that can go in here if you think it is worthwhile, i.e., it increases either teh accuracy or the computational performance of the rsults.

@duodenum96
Copy link
Author

Do you instead want to enhance the current IAFFT algorithm to instead of use the standard FFT to compute the spectrum, to instead use the Welch's method?

This one. Thanks, I'll get to it and do some tests to see if it is worthwhile or not.

@kahaaga
Copy link
Member

kahaaga commented May 22, 2024

Since this involves averaging multiple periodograms, I guess it will be more time-consuming than using a single estimate of the periodogram? I suggest that if you implement this, @duodenum96, the user should be able to pick whether they want to estimate the periodogram using the standard FFT method or by averaging, depending on their needs.

@duodenum96
Copy link
Author

Of course, you are right. I wrote a small matlab code that does this and it is working as intended. I am getting familiar with the coding style of TimeseriesSurrogates.jl now, I will implement it in Julia after I figure out the process.

@kahaaga
Copy link
Member

kahaaga commented May 22, 2024

Excellent! Looking forwards to your contribution :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants