From c0e42673c6af5dcea7997e1a90c2eccc4008f124 Mon Sep 17 00:00:00 2001 From: Arhik Date: Wed, 21 Jan 2026 17:21:34 +0530 Subject: [PATCH] replace unsigned only varint calls with `encode_varint!` - Replace encode_signed_varint with encode_varint for FloatIdentityOp bits since float_to_bits returns unsigned values - Remove redundant encode_signed_varint overload in writer.jl that just wrapped encode_varint anyway --- src/bytecode/writer.jl | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/src/bytecode/writer.jl b/src/bytecode/writer.jl index e471de5..e09c839 100644 --- a/src/bytecode/writer.jl +++ b/src/bytecode/writer.jl @@ -264,7 +264,7 @@ function encode_tagged_float!(cb::CodeBuilder, identity::FloatIdentity) encode_typeid!(cb.buf, identity.type_id) # Value as bits (using signed varint encoding for values <= 64 bits) bits = float_to_bits(identity.value, identity.dtype) - encode_signed_varint!(cb.buf, bits) + encode_varint!(cb.buf, bits) end """ @@ -290,17 +290,6 @@ function float_to_bits(value::Float64, ::Type{T}) where T reinterpret(UInt32, Float32(value)) end -""" - encode_signed_varint!(buf, value) - -Encode a signed integer as a variable-length integer. -Uses zigzag encoding for signed values. -""" -function encode_signed_varint!(buf::Vector{UInt8}, value::Union{UInt16, UInt32, UInt64}) - # For float bits, encode as unsigned varint - encode_varint!(buf, UInt64(value)) -end - """ encode_identity_array!(cb, identities) @@ -544,7 +533,7 @@ function finalize_function!(func_buf::Vector{UInt8}, cb::CodeBuilder, end #============================================================================= - Optimization Hints + Optimization Hints =============================================================================# """