Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled tests by adding opencv_extra as a lazy artifact #25

Merged

Conversation

stemann
Copy link
Contributor

@stemann stemann commented Aug 1, 2023

Enabled tests to run - rather than just skipping them when opencv_extra is not in ENV.

@stemann stemann force-pushed the feature/stemann/enable_tests branch from 9c77a4f to ccd631d Compare August 1, 2023 09:57
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d6919cf) 100.00% compared to head (af23e7b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stemann stemann force-pushed the feature/stemann/enable_tests branch from 476b2c3 to af23e7b Compare August 1, 2023 10:17
@stemann
Copy link
Contributor Author

stemann commented Aug 1, 2023

Testing on x86 (on ubuntu) was disabled due to a very basic error stemming from just creating a CxxWrap StdString from

img_gray = OpenCV.imread(joinpath(test_dir, "shared", "pic1.png"), OpenCV.IMREAD_GRAYSCALE)

Cf. https://github.com/JuliaImages/OpenCV.jl/actions/runs/5725287556/job/15513486710#step:6:188

Looks like it's this: JuliaInterop/CxxWrap.jl#310

Copy link
Member

@ashwani-rathee ashwani-rathee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks alright, do we need specifically LazyArtifacts for making artifact download lazy?

test/test_feature2d.jl Show resolved Hide resolved
@ashwani-rathee ashwani-rathee merged commit 1bb1abc into JuliaImages:master Aug 2, 2023
10 checks passed
@stemann stemann deleted the feature/stemann/enable_tests branch August 2, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants