Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iostream test failing in CI #56219

Closed
d-netto opened this issue Oct 17, 2024 · 1 comment · Fixed by #56220
Closed

iostream test failing in CI #56219

d-netto opened this issue Oct 17, 2024 · 1 comment · Fixed by #56220
Labels
bug Indicates an unexpected problem or unintended behavior ci Continuous integration

Comments

@d-netto
Copy link
Member

d-netto commented Oct 17, 2024 

iostream                                         (18) |        started at 2024-10-17T18:31:30.354
      From worker 7:	Test Summary:    | Pass  Total  Time
      From worker 7:	Task threadpools |    4      4  0.4s
iostream                                         (18) |         failed at 2024-10-17T18:31:36.047
Test Failed at /cache/build/tester-demeter6-10/julialang/julia-master/julia-ebe4c17d7c/share/julia/test/iostream.jl:190
  Expression: all((T->begin
            #= /cache/build/tester-demeter6-10/julialang/julia-master/julia-ebe4c17d7c/share/julia/test/iostream.jl:190 =#
            T <: Union{UInt, Int}
        end), Base.return_types(unsafe_write, (IO, Ptr{UInt8}, UInt)))

https://buildkite.com/julialang/julia-master/builds/41164#01929b9d-4e36-40cc-ac9b-fe794f9d0e07.
@d-netto d-netto added bug Indicates an unexpected problem or unintended behavior ci Continuous integration labels Oct 17, 2024
@fredrikekre
Copy link
Member

Maybe #53959? It adds a new IO and new methods to unsafe_write.

vtjnash added a commit that referenced this issue Oct 17, 2024
@vtjnash
REPL: fix unsafe_write return type
aca6229 
Fixes: #56219
@vtjnash vtjnash mentioned this issue Oct 17, 2024
Merged
KristofferC pushed a commit that referenced this issue Oct 21, 2024
@vtjnash
REPL: fix unsafe_write return type (#56220)
763c225 
Fixes: #56219

I am not really sure why we have a test for this, but we need to make
the test happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior ci Continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REPL: fix unsafe_write return type JuliaLang/julia
2 participants
@fredrikekre @d-netto