Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Documenter.jl to 1.0 #654

Merged
merged 6 commits into from
Sep 26, 2023
Merged

Update Documenter.jl to 1.0 #654

merged 6 commits into from
Sep 26, 2023

Conversation

mateuszbaran
Copy link
Member

No description provided.

@mateuszbaran mateuszbaran added documentation Improvements or additions to documentation Ready-for-Review A label for pull requests that are feature-ready preview docs Add this label if you want to see a PR-preview of the documentation labels Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #654 (89b8cc9) into master (9337b86) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #654   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files         106      106           
  Lines       10440    10440           
=======================================
  Hits        10359    10359           
  Misses         81       81           
Files Coverage Δ
src/manifolds/GeneralUnitaryMatrices.jl 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kellertuer
Copy link
Member

I am surprised about the large reduction of test coverage, any idea where that might come from?

@mateuszbaran
Copy link
Member Author

It's again that weird issue with first line of method not being covered 😕

@kellertuer
Copy link
Member

Seems to just be a hiccup every now and then.

Though I usually just retriever the action (under actions – rerun all) that looks a bit nicer in history compared to the close-reopen-trick.

@mateuszbaran mateuszbaran merged commit 71cd2aa into master Sep 26, 2023
25 checks passed
@kellertuer kellertuer deleted the mbaran/documenter-1.0 branch May 4, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation preview docs Add this label if you want to see a PR-preview of the documentation Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants