-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is base_manifold
supposed to commute with ProductManifold
?
#738
Comments
Uh, interesting! For now, the idea is, that it “undecorates”
So for now the answer to the question is: No. I think it could permute, but while it is a philosophical question whether it should (or one of: does someone need it and we provide it in the package for that reason), the larger problem might be the realisation,
for your case, which would require a (careful) recursive base manifold case. I personally do not have a strong opinion here. It should be done very carefully and would be a breaking change. |
Since That way the technical ‘“undecorate” action would stay as is (we do not have to care about all side effects changing this function would introduce) and we have a “more high level” function doing these more fine granular (and commuting) things. |
Yes, I think I will use this implementation in my code, this will suffice for my needs, I think. plain_manifold(M::ProductManifold) = ProductManifold(plain_manifold.(M.manifolds)...)
plain_manifold(M) = base_manifold(M) |
An alternative could be to use a keyword argument with the |
It is currently not the case, but perhaps it is supposed to work that way?
Example:
The text was updated successfully, but these errors were encountered: