Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe don't split distributions extension #757

Merged
merged 5 commits into from
Oct 19, 2024

Conversation

mateuszbaran
Copy link
Member

No description provided.

@mateuszbaran mateuszbaran added Ready-for-Review A label for pull requests that are feature-ready preview docs Add this label if you want to see a PR-preview of the documentation labels Oct 18, 2024
@mateuszbaran
Copy link
Member Author

JuliaFormatter v2 has some serious issues reported so maybe let's keep using v1 for now.

@kellertuer
Copy link
Member

v2 was even yanked I think, so while I look forward to it, since it does use JuliaSyntax – yes we should wait with that for sure.

@mateuszbaran mateuszbaran changed the title Split distributions extension Maybe don't split distributions extension Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (784a6b9) to head (04d4f84).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #757   +/-   ##
=======================================
  Coverage   96.38%   96.38%           
=======================================
  Files         123      123           
  Lines       11438    11438           
=======================================
  Hits        11025    11025           
  Misses        413      413           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mateuszbaran
Copy link
Member Author

I have no idea why the Manopt integration test suddenly fails... should we maybe try a different Julia version on CI?

@kellertuer
Copy link
Member

I also have no clue why it claims Manifolds is not in the dependencies there. That seems to be unrelated to the PR here?

@mateuszbaran
Copy link
Member Author

It is unrelated, so I will merge this anyway.

@mateuszbaran mateuszbaran merged commit 41e170d into master Oct 19, 2024
19 of 20 checks passed
@kellertuer
Copy link
Member

I do not even et all what the error message wants to tell me. And it worked before. So I have no clue what is happening there nor howI should debug a dependency error from within an Extension that is based on the package it reports to be missing?!

@mateuszbaran
Copy link
Member Author

Hopefully it will just resolve itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview docs Add this label if you want to see a PR-preview of the documentation Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants