Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce invertible matrices (merely for completeness) #764

Merged
merged 6 commits into from
Oct 24, 2024

Conversation

kellertuer
Copy link
Member

@kellertuer kellertuer commented Oct 23, 2024

This is merely for completeness and it makes a few steps in LieGroups.jl a bit easier/generic.

@kellertuer kellertuer added Ready-for-Review A label for pull requests that are feature-ready preview docs Add this label if you want to see a PR-preview of the documentation labels Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.40%. Comparing base (45b9cfa) to head (ce73ac3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #764   +/-   ##
=======================================
  Coverage   96.39%   96.40%           
=======================================
  Files         123      124    +1     
  Lines       11445    11473   +28     
=======================================
+ Hits        11032    11060   +28     
  Misses        413      413           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mateuszbaran mateuszbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
@kellertuer kellertuer merged commit c950edd into master Oct 24, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview docs Add this label if you want to see a PR-preview of the documentation Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants