Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rotation actions #765

Merged
merged 4 commits into from
Oct 25, 2024
Merged

New rotation actions #765

merged 4 commits into from
Oct 25, 2024

Conversation

mateuszbaran
Copy link
Member

Two actions useful in robotics and one new function.

@mateuszbaran mateuszbaran added Ready-for-Review A label for pull requests that are feature-ready preview docs Add this label if you want to see a PR-preview of the documentation labels Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (c950edd) to head (5cd41ac).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #765      +/-   ##
==========================================
+ Coverage   96.40%   96.41%   +0.01%     
==========================================
  Files         124      124              
  Lines       11473    11512      +39     
==========================================
+ Hits        11060    11099      +39     
  Misses        413      413              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/groups/rotation_action.jl Show resolved Hide resolved
src/groups/rotation_action.jl Outdated Show resolved Hide resolved
src/groups/rotation_action.jl Outdated Show resolved Hide resolved
@kellertuer
Copy link
Member

While we now have the rule in LieGroups, that one approval is necessary (unless overwritten on squash and merge), should we add that here as well?

@mateuszbaran
Copy link
Member Author

While we now have the rule in LieGroups, that one approval is necessary (unless overwritten on squash and merge), should we add that here as well?

OK, we can do that.

@mateuszbaran mateuszbaran merged commit cdfbe7f into master Oct 25, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview docs Add this label if you want to see a PR-preview of the documentation Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants