Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.1.0 Release Roadmap #1

Closed
30 of 32 tasks
heltonmc opened this issue Jan 8, 2022 · 11 comments
Closed
30 of 32 tasks

v0.1.0 Release Roadmap #1

heltonmc opened this issue Jan 8, 2022 · 11 comments

Comments

@heltonmc
Copy link
Member

heltonmc commented Jan 8, 2022

Float32

  • besselj0(x)
  • besselj1(x)
  • besselj(nu, x)
  • bessely0(x)
  • bessely1(x)
  • bessely(nu, x)
  • besseli(nu, x)
  • besseli0(x)
  • besseli0x(x)
  • besseli1(x)
  • besseli1x(x)
  • besselk(nu, x)
  • besselk0(x)
  • besselk0x(x)
  • besselk1(x)
  • besselk1x(x)

Float64

  • besselj0(x)
  • besselj1(x)
  • besselj(nu, x)
  • bessely0(x)
  • bessely1(x)
  • bessely(nu, x)
  • besseli(nu, x)
  • besseli0(x)
  • besseli0x(x)
  • besseli1(x)
  • besseli1x(x)
  • besselk(nu, x)
  • besselk0(x)
  • besselk0x(x)
  • besselk1(x)
  • besselk1x(x)
@heltonmc heltonmc pinned this issue Jan 8, 2022
@heltonmc heltonmc changed the title Bessels.jl implementation roadmap v0.1.0 Release Roadmap Feb 10, 2022
@heltonmc
Copy link
Member Author

heltonmc commented Aug 4, 2022

I'm thinking it might be a good time for a 0.1.0 release soon once #29 gets merged and an update to the readme?

We've now met all of these and a bit more with supporting any integer/noninteger order (pos or negative).

We might actually have a name conflict with BesselK.jl though ....

@oscardssmith
Copy link
Member

sounds great!

@cgeoga
Copy link
Contributor

cgeoga commented Aug 4, 2022

I also support a release. I can't wait to switch from using SpecialFunctions for the case v isa AbstractFloat to Bessels.besselk.

I don't think there should be a name conflict though---BesselK.jl only exports adbesselk and adbesselkxv. If you export besselk, you would have a conflict with SpecialFunctions.jl though.

@oscardssmith
Copy link
Member

I think that name conflict isn't a major problem. The solution is that SpecialFunctions in the future can make SpecialFunctions.besselk just re-export the Bessels.jl version.

@heltonmc
Copy link
Member Author

heltonmc commented Aug 4, 2022

Yes - I very much like that idea. I more so meant that Bessels.jl and BesselK.jl are too similar for the general registry to automatically merge, so will need a manual override I think.

Or we consider a name change of Bessels.jl.....

@cgeoga
Copy link
Contributor

cgeoga commented Aug 4, 2022

Oh wow, I didn't know that there were restrictions like that. I'm sorry for accidentally squatting on some valuable name real estate. It's hard to imagine anybody objecting to a manual override though. I suppose changing to, like, BesselFunctions wouldn't be insane either, but I would vote to try registering as-is and do the manual override. And apologies again for making this more complicated.

@heltonmc
Copy link
Member Author

heltonmc commented Aug 4, 2022

O not at all. Your package is aptly named but yes another option would be BesselFunctions.jl. I'm open for whatever is easier for the community on this.

I'd also be in support of moving this under the JuliaMath umbrella, but don't know that process.

@oscardssmith
Copy link
Member

I think Bessels.jl is appropriate. It might be too similar for automerge, but we can just merge it manually.

@oscardssmith
Copy link
Member

If you give me permissions to modify the settings of this repo, I think I can move it.

@heltonmc
Copy link
Member Author

heltonmc commented Aug 4, 2022

Hmmmm! I'm not for sure how to give you more permissions? I think you are already a collaborator but doesn't look like you can transfer this too an org? Should I transfer the repo to you then you can move it? Might be easier if I could just transfer over to JuliaMath but I don't know who to get approval from there.

@oscardssmith
Copy link
Member

I can give approval for the transfer.

@heltonmc heltonmc closed this as completed Aug 8, 2022
@heltonmc heltonmc unpinned this issue Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants