Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large argument inaccuracy for Float32 in besselj0 #90

Open
heltonmc opened this issue Apr 11, 2023 · 0 comments · May be fixed by #93
Open

Large argument inaccuracy for Float32 in besselj0 #90

heltonmc opened this issue Apr 11, 2023 · 0 comments · May be fixed by #93
Labels
bug Something isn't working

Comments

@heltonmc
Copy link
Member

heltonmc commented Apr 11, 2023 •
edited
Loading 

julia> Bessels.besselj0(328049.34f0)
-0.0013240778f0

julia> Bessels.besselj0(Float64(328049.34f0))
-0.0013258623831875669

I'm imagining the better sin sum here could help.

Originally posted by @heltonmc in #88 (comment)

The fix should be with the better sin_sum PR. Need to test further.
@heltonmc heltonmc mentioned this issue Apr 11, 2023
Merged
@heltonmc heltonmc added the bug Something isn't working label Apr 12, 2023
@heltonmc heltonmc linked a pull request Apr 21, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use better sin_sum for F32 heltonmc/Bessels.jl
1 participant
@heltonmc