Simplify and improve ilog2(::Real) #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Simplify ilog2 for built in bitstype floats and BigFloat by calling exponent. * Some missing tests are added for RoundUp and RoundDown with floating point arguments. An undetected bug was fixed and is tested by these tests. In fact, it's hard to identify a clear advantage of any of the remaining methods compared to `ilog2(x:Any) = exponent(float(x::Any))`. Closes JuliaMath#8
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify
ilog2for built in bitstype floats andBigFloatby calling exponent.Some missing tests are added for
RoundUpandRoundDownwith floating point arguments. An undetected bug was fixed and is tested by these tests.In fact, it's hard to identify a clear advantage of any of the remaining methods compared to
ilog2(x::Any) = exponent(float(x::Any)).Closes #8