Fix compats for MeasureBase and drop 1.3 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see the tests are only testing from 1.6, does that mean we should change the julia compat to 1.6 instead of 1.3? This should also avoid the need for all the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #139 +/- ##
=======================================
Coverage 54.05% 54.05%
=======================================
Files 43 43
Lines 1221 1221
=======================================
Hits 660 660
Misses 561 561 ☔ View full report in Codecov by Sentry. |
|
|
theogf
changed the title
|
oschulz
approved these changes
Jan 27, 2024
|
Ok, here we go: JuliaRegistries/General#99684 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the separation of the
stdlibswith 1.9 we need compats on stdlibs as well, notably for theAquatests to pass