Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxyfuns #151

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

proxyfuns #151

wants to merge 1 commit into from

Conversation

cscherrer
Copy link
Collaborator

MeasureTheory.jl currently has functions like this:

StatsBase.entropy(m::AbstractMeasure, b::Real) = entropy(proxy(m), b)
Statistics.mean(m::AbstractMeasure) = mean(proxy(m))
Statistics.std(m::AbstractMeasure) = std(proxy(m))
Statistics.var(m::AbstractMeasure) = var(proxy(m))
Statistics.quantile(m::AbstractMeasure, q) = quantile(proxy(m), q)

But proxy is defined in MeasureBase, so this is type piracy. Better to move them here if possible.

@codecov Codecov
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 53.36%. Comparing base (3d1084f) to head (e88e952).

Files with missing lines Patch % Lines
src/rand.jl 0.00% 9 Missing ⚠️
src/utils.jl 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   53.97%   53.36%   -0.62%     
==========================================
  Files          43       43              
  Lines        1219     1233      +14     
==========================================
  Hits          658      658              
- Misses        561      575      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oschulz
Copy link
Collaborator

oschulz commented Sep 28, 2024

I'd like to pull this into the other major changes I'm working on - the resulting version of MeasureBase will require Julia v1.10 (designated as the next LTS), so we can so this via an extension then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oschulz oschulz Awaiting requested review from oschulz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cscherrer @oschulz