New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why are method2 and method3 mutually exclusive? #26

Open

vsaase opened this issue Sep 6, 2019 · 1 comment

vsaase commented Sep 6, 2019 •

edited

Loading

https://github.com/JuliaIO/NIfTI.jl/blob/a9e50b9f6ddf5e8b7c09fffdfe9a3d48a962c0fe/src/NIfTI.jl#L344

Hi, the nifti standard (https://nifti.nimh.nih.gov/nifti-1/documentation/nifti1fields/nifti1fields_pages/qsform.html) does'nt say that.

also here
https://github.com/JuliaIO/NIfTI.jl/blob/a9e50b9f6ddf5e8b7c09fffdfe9a3d48a962c0fe/src/NIfTI.jl#L366
why do you write method2 || method3, this leads to a problem with e.g. ITK-SNAP which then thinks it can use method2, even if only method3 is availabe

vsaase changed the title ~~Why are method2 and method 2 mutually exclusive?~~ Why are method2 and method3 mutually exclusive?

Member

Tokazama commented Sep 6, 2019

You're correct. However, last I checked ITK only uses the sform. They may have changed this though. Either way we need to fix this.

stefanches7 mentioned this issue

fix method 2 and 3 responsibilities #35

Open

Tokazama added a commit that referenced this issue


          Fix affine methods

f61a7c1

This should fix #53 and #26

Tokazama mentioned this issue

Fix affine values #54

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment