Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIfTI-2 support #69

Open
PallHaraldsson opened this issue Sep 26, 2023 · 4 comments
Open

NIfTI-2 support #69

PallHaraldsson opened this issue Sep 26, 2023 · 4 comments

Comments

@PallHaraldsson
Copy link

I see from the source code you support NIfTI-1, but it's unclear if you support NIfTI-2 too, and both endian formats.

https://brainder.org/2015/04/03/the-nifti-2-file-format/

I think it should be documented either way. Do you know which is the most common format, and do you plan to support both?

@Tokazama
Copy link
Member

Tokazama commented Oct 4, 2023

It's not supported yet, but I do have the basic code in place. If I can muster up a days work for managing some slightly breaking changes and more comprehensive tests it should get done. I wish I could give a time estimate but I'm stuck in the middle of two papers and a thesis so my OSS contributions are pretty slow.

@PallHaraldsson
Copy link
Author

PallHaraldsson commented Oct 4, 2023

No pressure, I was just curious. I use neither. I suggest documenting only NIfTI-1 is supported (for now; in the README? this issue sort of does too), and that NIfTI-2 also exists and its support is on the TODO list.

What about both endian formats?

@PallHaraldsson PallHaraldsson changed the title NIfTI-2 support? NIfTI-2 support Oct 4, 2023
@Tokazama
Copy link
Member

Tokazama commented Oct 4, 2023

It detects whether the endian format a file is saved in and byte swaps accordingly. Users shouldn't really have to worry about that for NIfTI.

Some of the apprehension behind jumping into breaking changes for NIfTI-2 is that any software that supports it for standard MRIs also supports NIfTI-1 but the inverse is not true. v2 is also used for CIFTI in some cases. So it becomes a bit of a user interface nightmare if not done with a lot of thought and care.

@calvinchai
Copy link
Contributor

Hello, is there any progress to this? I can propose some changes and make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants