You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
EDIT: part of the problem is we removing Graphs.jl which removes drawing utils, so basically we just need an end-to-end test of IIF.animateCSMSideBySide with all the necessary deprecations. The types and names are all slightly changed, so yes just a solid round of deprecations required all round here.
More breaking type changes between Caesar / IIF / FSM that were not properly deprecated. The type has been changed to NamedTuple:
We should add animateCSM the tests to make sure this does not happen again. I ask for help on getting broader test coverage please, especially if type changes are made.
EDIT: part of the problem is we removing Graphs.jl which removes drawing utils, so basically we just need an end-to-end test of
IIF.animateCSMSideBySide
with all the necessary deprecations. The types and names are all slightly changed, so yes just a solid round of deprecations required all round here.More breaking type changes between Caesar / IIF / FSM that were not properly deprecated. The type has been changed to
NamedTuple
:Some of the debug tools from Caesar call upstream through IIF into FSM
https://github.com/JuliaRobotics/IncrementalInference.jl/blob/4e9f088f336618377aa8481ee9068c72f1f41f17/src/TreeDebugTools.jl#L757
But FSM wants the old
Tuple
type:As well as
Dict
of eitherInt
orSymbol
.We should add
animateCSM
the tests to make sure this does not happen again. I ask for help on getting broader test coverage please, especially if type changes are made.cc @Affie
The text was updated successfully, but these errors were encountered: