Skip to content

Commit 531c51e

Browse files
Merge pull request #15 from JunbaeJs/refactor-setting
Refactor setting
2 parents 2acf6f2 + a5dd424 commit 531c51e

File tree

4 files changed

+66
-19
lines changed

4 files changed

+66
-19
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,25 +4,28 @@ about: Create a report to help us improve
44
title: Bug
55
labels: bug
66
assignees: changchanghwang
7-
87
---
98

10-
|name|about|title|labels|assignees|
11-
|--|--|--|--|--|
12-
|💩Bug report|Create a report to help us improve||||
9+
| name | about | title | labels | assignees |
10+
| ------------ | ---------------------------------- | ----- | ------ | --------- |
11+
| 💩Bug report | Create a report to help us improve | | | |
12+
13+
### Describe the bug
1314

14-
### Describe the bug
1515
A clear and concise description of what the bug is.
1616

17-
### Expected behavior
17+
### Expected behavior
18+
1819
A clear and concise description of what you expected to happen.
1920

2021
### Example Code
22+
2123
```ts
22-
console.log('hello world')
24+
console.log('hello world');
2325
```
2426

2527
### Information
28+
2629
Version[e.g. v0.1.0]:
2730
OS[e.g. iOS]:
2831
Browser[e.g. chrome 62]:

.github/ISSUE_TEMPLATE/feature_request.md

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,26 +3,29 @@ name: Feature request
33
about: Suggest an idea for this project
44
title: Feature
55
labels: enhancement
6-
assignees: ActaV-N, sm9657, changchanghwang
7-
6+
assignees: changchanghwang
87
---
98

10-
|name|about|title|labels|assignees|
11-
|--|--|--|--|--|
12-
|✨Feature|this is a awesome feature||||
9+
| name | about | title | labels | assignees |
10+
| --------- | ------------------------- | ----- | ------ | --------- |
11+
| ✨Feature | this is a awesome feature | | | |
12+
13+
### Describe the feature
1314

14-
### Describe the feature
1515
A clear and concise description of what the feature do.
1616

17-
### Expected behavior
17+
### Expected behavior
18+
1819
A clear and concise description of what you expected to happen.
1920

2021
### Example Code
22+
2123
```ts
22-
console.log('hello world')
24+
console.log('hello world');
2325
```
2426

2527
### Information
28+
2629
Version[e.g. v0.1.0]:
2730
OS[e.g. iOS]:
2831
Browser[e.g. chrome 62]:

.github/workflows/pr-ci.yml

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
name: ci when pull request
2+
3+
on:
4+
pull_request:
5+
types: [opened, synchronize, reopened]
6+
7+
jobs:
8+
release:
9+
runs-on: ubuntu-latest
10+
11+
strategy:
12+
matrix:
13+
node-version: [20.11.x]
14+
15+
permissions:
16+
contents: write # to be able to publish a GitHub release
17+
issues: write # to be able to comment on released issues
18+
pull-requests: write # to be able to comment on released pull requests
19+
id-token: write # to enable use of OIDC for npm provenance
20+
21+
steps:
22+
- name: Checkout
23+
uses: actions/checkout@v3
24+
- name: Use Node.js ${{ matrix.node-version }}
25+
uses: actions/setup-node@v3
26+
with:
27+
node-version: ${{ matrix.node-version }}
28+
cache: 'npm'
29+
- name: Cache node modules
30+
uses: actions/cache@v2
31+
with:
32+
path: node_modules
33+
key: ${{ runner.OS }}-build-${{ hashFiles('**/package-lock.json') }}
34+
restore-keys: |
35+
${{ runner.OS }}-build-
36+
${{ runner.OS }}-
37+
- name: Package install
38+
run: npm ci
39+
- name: lint
40+
run: |
41+
npm run lint

CONTRIBUTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Thank you for showing interest in Junbae-mode and we appreciate any contribution
44

55
## Report a Bug or Feature
66

7-
Whenever you find something which is not working properly, please first search the repository's issue page and make sure it's not reported by someone else already.
7+
Whenever you find something that is not working properly, please first search the repository's issue page and make sure it's not reported by someone else already.
88

99
Before creating an issue, check the `Issue Template` for guidelines. Provide as much detail as possible.
1010

@@ -28,7 +28,7 @@ git checkout -b [branch name or issue number]
2828

2929
```sh
3030
# example
31-
git commit -m "feat:~~"
31+
git commit -m "your message"
3232
```
3333

3434
</br>
@@ -51,10 +51,10 @@ git push origin [branch name or issue number]
5151

5252
```
5353
breaking: top-level version bump. used for major framework changes or large-scale project deployments.
54-
feat: new feature for the user, not a new feature for build script
54+
feat: new feature for the user, not a new feature for building script
5555
fix: bug fix for the user, not a fix to a build script
5656
docs: changes to the documentation
57-
style: formatting, missing semi colons, etc; no production code change
57+
style: formatting, missing semi-colons, etc; no production code change
5858
refactor: refactoring production code, eg. renaming a variable
5959
test: adding missing tests, refactoring tests; no production code change
6060
chore: updating grunt tasks etc; no production code change

0 commit comments

Comments
 (0)