Fix tempest test_associate_floating_ip_with_port_from_another_project

Return 400 instead of 404 on floatingip update with port
from another project.

Closes-Bug: #1807447
Change-Id: Icb58b681fa89b36552ac65f22ad3612ad7dd6958

Author: Anton Arefiev

src/config/vnc_openstack/vnc_openstack/neutron_plugin_db.py

@@ -2388,7 +2388,10 @@ def _floatingip_neutron_to_vnc(self, context, fip_q, oper):
                 port_tenant_id = self._get_obj_tenant_id('port', port_id)
                 if context and not context['is_admin']:
                     if port_tenant_id != context['tenant'].replace('-', ''):
-                        raise NoIdError(port_id)
+                        self._raise_contrail_exception(
+                            'BadRequest',
+                            resource='floatingip',
+                            msg='Port %s is from another project' % port_id)
 
                 fip_proj_list = fip_obj.get_project_refs()
                 if fip_proj_list:

src/config/vnc_openstack/vnc_openstack/tests/test_vnc_plugin_db.py

@@ -6,6 +6,8 @@
 from flexmock import flexmock
 import sys
 
+import bottle
+
 from . import fake_neutron
 from vnc_openstack import neutron_plugin_db as db
 from cfgm_common.tests.test_utils import FakeKazooClient
@@ -208,3 +210,27 @@ def _sg_delete(id):
                 '%s/%s' %
                 (dbi.security_group_lock_prefix, sg_uuid))
             dbi.security_group_delete(context, sg_uuid)
+
+    def test_floating_update_port_from_another_project(self):
+        dbi = MockDbInterface()
+        dbi._get_obj_tenant_id=lambda r, id: 'Another project'
+
+        dbi._vnc_lib = flexmock(
+            fq_name_to_id=lambda res, name: 'fip_pool_uuid',
+            floating_ip_read=lambda id: 'fip_obj',
+            virtual_machine_interface_read=lambda id, fq_name, fields: None,
+            logical_routers_list=lambda parent_id, detail: [
+                flexmock(uuid='router_uuid',
+                         get_virtual_machine_interface_refs=lambda: [{'uuid': 'router_port_uuid'}])])
+
+        id_perms_obj = flexmock(
+            uuid='id_perms_uuid',
+            get_created=lambda: 'create_time',
+            get_last_modified=lambda: 'last_modified_time',
+            get_description=lambda: 'description')
+
+        with self.assertRaises(bottle.HTTPError):
+            fip_neutron = dbi._floatingip_neutron_to_vnc(
+                {'tenant': 'tenant', 'is_admin': False},
+                {'id': 1, 'port_id': 11},
+                db.UPDATE)