Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate commands into single command #11

Closed
JvstvsHD opened this issue May 25, 2024 · 0 comments · Fixed by #38
Closed

Migrate commands into single command #11

JvstvsHD opened this issue May 25, 2024 · 0 comments · Fixed by #38
Assignees
@JvstvsHD
Labels
enhancement New feature or request

Comments

@JvstvsHD
Copy link
Owner

JvstvsHD commented May 25, 2024 •
edited
Loading

As of now, for all functions exists one single, extra command (/ban, /unban, ...). Since those sometimes clash with other commands from other sources (e.g. /ban and /whitelist from Bukkit based servers), they should all be merged into one single command with all respective branches (/necrify ban ... instead of /ban). There still should be the config option to allow those top-level-commands, which will be enabled by default. To accommodate with multi-platform support, this command should be done with the cloud framework.

Current progress: #38
@JvstvsHD JvstvsHD added the enhancement New feature or request label May 25, 2024
@JvstvsHD JvstvsHD self-assigned this May 25, 2024
JvstvsHD added a commit that referenced this issue Jul 14, 2024
@JvstvsHD
API: add succeeding punishments (#9)
0382983 
Punishments API-wise can now have a successor.
Replace direct instantiation of punishments in module plugin-common with PunishmentBuilder.

WIP: save successors
Implement successor being set when needed --> probably after #11
JvstvsHD added a commit that referenced this issue Jul 21, 2024
@JvstvsHD
Initialize work for #11
5278d92 
Add a base structure for all commands
@JvstvsHD JvstvsHD moved this from Todo to In Progress in VelocityPunishment v1.2.x Jul 21, 2024
@JvstvsHD JvstvsHD moved this from Todo to In Progress in Support Paper (+ BungeeCord) Jul 21, 2024
@JvstvsHD JvstvsHD mentioned this issue Jul 21, 2024
Merged
7 tasks
@JvstvsHD JvstvsHD linked a pull request Jul 28, 2024 that will close this issue
Feature/cloud commands #38
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in VelocityPunishment v1.2.x Jul 28, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Support Paper (+ BungeeCord) Jul 28, 2024
JvstvsHD added a commit that referenced this issue Jan 21, 2025
@JvstvsHD
Fix documentation #11
1923a94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JvstvsHD JvstvsHD

Labels
enhancement New feature or request
Projects
Support Paper (+ BungeeCord)
Status: Done
VelocityPunishment v1.2.x
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/cloud commands JvstvsHD/necrify
1 participant
@JvstvsHD