Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tucker Decomposition collapses to o #2

Open
secrestb opened this issue Dec 16, 2024 · 1 comment
Open

Tucker Decomposition collapses to o #2

secrestb opened this issue Dec 16, 2024 · 1 comment

Comments

@secrestb
Copy link

From tucker_decomposition_conv_layer(layer, target_ratio_):

The line : left, right = 0, len(S) - 1 causes an error if it actually reaches 0. If it does reach 0, then the rank is 0 and when it attempts to create a tensor with shape 0 it fails. To prevent this, the line should be left, right = 1, len(S) - 1

@K0EKJE
Copy link
Owner

K0EKJE commented Dec 21, 2024

From tucker_decomposition_conv_layer(layer, target_ratio_):

The line : left, right = 0, len(S) - 1 causes an error if it actually reaches 0. If it does reach 0, then the rank is 0 and when it attempts to create a tensor with shape 0 it fails. To prevent this, the line should be left, right = 1, len(S) - 1

I think it makes sense. Yes, the threshold in SVT is 'strictly larger than' so both left and right cannot be 0. Thank you for pointing out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants