Introducing cmake-format

[OlivierLDff]

C++ code is formatted by clang format, rust with rustfmt, cargo file with magic (I don't know what format toml, but it is auto formatted somehow in my ide). Only cmake file are manually formatted which is annoying.

Basic config .cmake-format could look like that to match the style already used.

format:
  tab_size: 4
  dangle_parens: true

Special configuration will be required for corrosion functions.

I know the project isn't maintained in the recent years, and sometime formatting look weird, but a least it is automatic.

What are you tought about that?

[ahayzen-kdab]

Anything which is machine driven and can be added to CI for formatting or linting is good :-)

Is cmake-format the generally accepted solution across CMake projects ? Or are there other options available ? Are you able to point to any large / well know CMake projects using it ?

As being old and not maintained is not necessarily bad if it works, however it is bad if it creates false positives with modern syntax or is hard to get through distribution mechanisms.

And the same would be said about cmake-lint.

Probably best way is to add it to CI for Linux, either like reuse via pip or via apt and see how it reacts / what the difference in the CMake files is.

[ahayzen-kdab]

Nope, i just press format in the IDE 😅 pre-commit would be the long term route to do this all properly if that could be hooked into our thing to find the C++ files etc as well.

[ahayzen-kdab]

Also moving to pre-commit would help with the differing versions of clang-format etc as well as IIRC you can pin it to a version

[OlivierLDff]

I've never had to use pre-commit yet as I'm also used to everything being formatted correctly when I save in my IDE. I will see how to do that.
I feel that cmake needs some refactoring, especially around add_test as there is a lot of duplicated code. I'm seeing that while doing my PR to fix ctest on windows.

[ahayzen-kdab]

Feel free to split out general changes into other pull requests while you battle fixing the Windows specific issues :-)

[OlivierLDff]

I'll first fix the windows problem, then do some general refactor if I have time. Fixing the windows issue force me to go thru every CMakeLists and get good understanding of the project as a whole ;)