Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Duplicates from search #103

Open
abourn opened this issue May 14, 2018 · 1 comment
Open

[FIX] Duplicates from search #103

abourn opened this issue May 14, 2018 · 1 comment

Comments

@abourn
Copy link
Collaborator

abourn commented May 14, 2018

  • Check if the release group id exists in results before adding
  • But, how do we handle cases in which certain releases within a release-group actually have more or less tracks...? For example, M.I.A.
@abourn
Copy link
Collaborator Author

abourn commented May 15, 2018

This may turn into a more general search enhancement for v2. For example, we want to have duplicates when a release is being indexed on a different field (e.g. track title is the same as track release). In trying to resolve this, checking if the current node has that specific release and that specific index info before adding to the trie (nodeContainsRelease() of trie.go; check would be val.ReleaseID == releaseID && val.FieldMatchedOn == fieldToIndex) seems to break other behavior (i.e., not indexing as much as it should).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant